Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit PR to get on Metamask #223

Closed
treeder opened this issue Jun 19, 2018 · 2 comments
Closed

Submit PR to get on Metamask #223

treeder opened this issue Jun 19, 2018 · 2 comments
Assignees

Comments

@treeder
Copy link
Collaborator

treeder commented Jun 19, 2018

Looks like we could submit a PR changing these files:

https://github.com/MetaMask/metamask-extension/blob/develop/docs/adding-new-networks.md

@r-gochain
Copy link
Contributor

@treeder seems like need to contact them first

  1. The doc is outdated (some files from link above one are absent and the doc is ~1 year old)
  2. Check this discussion - add POA.network support MetaMask/metamask-extension#2815 seems like they just added ability to use any custom endpoint and that's all, and also this discussion - RFC: Supporting ETH-like Networks MetaMask/metamask-extension#3604
  3. I also checked the code and found that custom URLs are not supported at all (ie - https://github.com/MetaMask/metamask-extension/blob/develop/old-ui/lib/etherscan-prefix-for-network.js those are prefixes for .infura.io - all endpoints are on this domain)

@treeder thoughts?

@treeder
Copy link
Collaborator Author

treeder commented Jun 22, 2018

So sounds like they aren't open to it yet huh? Guess we'll have to wait.

@treeder treeder closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants