Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

This broke our CI pipeline for several projects :'( #296

Closed
sio4 opened this issue Nov 20, 2021 · 2 comments · Fixed by #297
Closed

This broke our CI pipeline for several projects :'( #296

sio4 opened this issue Nov 20, 2021 · 2 comments · Fixed by #297

Comments

@sio4
Copy link
Member

sio4 commented Nov 20, 2021

Hi @JDiPierro,

I read your following comment on the PR for packr/v2. Could you please add some more information or symptom of the issue + a brief description of your use case + your environment?

--- the original comment ---
This broke our CI pipeline for several projects :'(

The installation methods in the README need to be updated.

$ go get -u github.com/gobuffalo/packr/v2/packr2

this no longer works.

Originally posted by @JDiPierro in #295 (comment)
@chuijh
Copy link

chuijh commented Nov 20, 2021

We had the same issue and ended up removing the v2 from the path

@sio4
Copy link
Member Author

sio4 commented Nov 21, 2021

I see. If you are able to install packr2 by running the command as follows, it must be an issue of the go version. By version 1.16 of go, which is our minimum supported version, the behavior of go get changed to enable GO111MODULE=on by default, and the package argument resolution automatically translates version part of the package (v2 of .../packr/v2) argument. If it was just treated as a path on the source tree, it seems like you are using GOPATH mode in your environment.

Will update the doc accordingly.

go get -u github.com/gobuffalo/packr/packr2

@sio4 sio4 mentioned this issue Nov 21, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed readme and version bump up
2 participants
@sio4 @chuijh