Incremental TD3: restart destabilized side-effected variables #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of replacing them with empty sets.
This avoids unnecessary work during solving. It also prevents spurious infls that disappear during narrowing.
They can be removed right after incremental loading. They aren't used during solving. They will be repopulated for incremental saving.
These require restarting globals during non-incremental solving.
|
I think unmarshalling version.data is stuck... can you try doing this in the bench repo: Can you reproduce it? |
2 tasks
This currently still works with restart_only_globals=true, because destabilize_with_side follows all side effects nevertheless.
|
We decided to start merging some of these together into the branch |
This was referenced Oct 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to restart destabilized side-effected variables (at least globals, but could also be function entry nodes in presence of partial contexts) to bottom when loading previous results. This allows globals (and especially their protecting locksets) to improve after fixing the program.
At loading time, obsolete nodes are destabilized with a special
destabilize_with_sidefunction instead. This requires knowinginflfor side effects (inside_infl) but also dependencies for side effects (inside_dep) to replay the unchanged ones. Both additional mappings are constructed duringreachabilityat saving time.TODO
FromSpec-specific hack inside TD3.