feat: dismiss a footnote when touching outside it #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your improvement! Can you add a couple of tests to cover this behaviour, please? |
This option is especially useful if the footnote is expanded inline instead of in a popover because then it doesn't make sense to hide it when clicking another place in the document.
jminer
force-pushed
the
opt-dismiss-doc-touch
branch
from
b9fb437
to
c39ed5e
Compare
|
Sure, I added some tests and just pushed them. The first test is testing the behavior of the new setting, and the second and third are the same same other tests and just check that the new setting doesn't change their behavior. Besides the first test, I wasn't sure what to add, but these are what I thought most likely to get broken. Are these about what you were thinking? I'm happy to change them or add another if you'd like. |
|
This looks good, thank you! |
goblindegook
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a design for footnotes showing them inline rather than in popovers. You can see an example at https://www.prisonpolicy.org/reports/pie2023.html. When footnotes are shown inline, it makes more sense to leave the footnote open when clicking elsewhere on the page. We used to hack in support to Bigfoot and Littlefoot 3.4 to not close the footnote, but I recently updated the site to use the latest Littlefoot 4.0 (with the code in this PR) and wanted to check your interest in having an option for it. What do you think? If you'd like, I could add some documentation.
Thanks for your work!