Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorldToScreen returns false when it shouldn't #1881

Closed
anna-is-cute opened this issue Jul 2, 2024 · 4 comments
Closed

WorldToScreen returns false when it shouldn't #1881

anna-is-cute opened this issue Jul 2, 2024 · 4 comments
Labels
api 10 regression

Comments

@anna-is-cute
Copy link
Contributor

Noticed this in Peeping Tom, but you can reproduce it in the /xldata object table viewer. None of the labels will draw because it returns false. Whether this is a problem with the Location property or a problem with WorldToScreen itself, I do not know.
@wolfcomp
Copy link
Contributor

wolfcomp commented Jul 2, 2024

Check what Umbra is doing since i know it uses a similar method. It was something that we noticed with 7.0 being a bit broken.

@pohky
Copy link
Contributor

pohky commented Jul 3, 2024

oh didn't see this or i would've mentioned it in the pr
#1885 should solve this

@goaaats
Copy link
Member

goaaats commented Jul 3, 2024

@anna-is-cute Please close if this works for you now!

@anna-is-cute
Copy link
Contributor Author

Sorry, I was asleep. Looks fixed to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api 10 regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anna-is-cute @pohky @wolfcomp @goaaats