Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: invisible trust prompt in 3.34.0 when using remote Taskfile #1486

Closed
tylerchr opened this issue Jan 26, 2024 · 3 comments · Fixed by #1487
Closed

Regression: invisible trust prompt in 3.34.0 when using remote Taskfile #1486

tylerchr opened this issue Jan 26, 2024 · 3 comments · Fixed by #1487
Labels
area: remote Changes related to remote taskfiles.

Comments

@tylerchr
Copy link

My coworker @wburningham had me install and run task using a remote Taskfile, and we were both surprised to see a very unhelpful prompt where it seems the remote Taskfile trust prompt should have been. After some investigation it seems to be a regression between 3.31.0 and 3.34.0.

A simple repro case:

# Taskfile.yml
version: "3"

includes:
  scary: https://raw.githubusercontent.com/go-task/task/main/docs/Taskfile.yml

Get both versions of task:

$ mkdir task3.33.1 task3.34.0
$ curl -Ls https://github.com/go-task/task/releases/download/v3.33.1/task_darwin_arm64.tar.gz | tar -xvzf - -C task3.33.1
$ curl -Ls https://github.com/go-task/task/releases/download/v3.34.0/task_darwin_arm64.tar.gz | tar -xvzf - -C task3.34.0

With 3.33.1:

$ ./task3.33.1/task --list 
The task you are attempting to run depends on the remote Taskfile at "https://raw.githubusercontent.com/go-task/task/main/docs/Taskfile.yml".
--- Make sure you trust the source of this Taskfile before continuing ---
Continue? [y/N]

With 3.34.0:

$ ./task3.34.0/task --list
 [y/N]

An additional oddity was that with task 3.34.0 I was prompted (with the empty prompt) on nearly invocation, whereas on task 3.33.1 it seemed to remember my answer. As a new task user I don't know whether that's related to the same root cause, but it seems possible.

  • Task version: 3.33.1 vs 3.34.0
  • Operating system: macOS 14.2
  • Experiments enabled: None, I assume. I just installed task.
@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Jan 26, 2024
@wburningham
Copy link

One clarification:

Experiments enabled: TASK_X_REMOTE_TASKFILES=1

Both @tylerchr and I have the ENV set

@pd93
Copy link
Member

pd93 commented Jan 27, 2024

@tylerchr @wburningham Thanks for the report. Pretty silly mistake on my part. Have opened #1487 to fix.

@pd93 pd93 added type: bug Something not working as intended. area: remote Changes related to remote taskfiles. and removed state: needs triage Waiting to be triaged by a maintainer. labels Jan 27, 2024
@andreynering
Copy link
Member

Thanks for reporting! The fix has just been released.

@pd93 pd93 removed the type: bug Something not working as intended. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: remote Changes related to remote taskfiles.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants