Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmd platform independent #1400

Open
gabyx opened this issue Nov 14, 2023 · 0 comments
Open

Make cmd platform independent #1400

gabyx opened this issue Nov 14, 2023 · 0 comments
Labels
state: needs triage Waiting to be triaged by a maintainer.

Comments

@gabyx
Copy link

gabyx commented Nov 14, 2023

Great tool!

However, I am really wondering why cmd is really a string. Isn't this bringing all the caveats with shells and quoting/word splitting to the table.
I really hoped to at least see something like cmd: ["docker", "run", ...] which is actually the most sane way to specify a pure command on any OS. I did the same in Githooks.

So I propose to make the cmd variable at least string|[]string which means

  • string : Normal shell execution what ever the shell is on the system. Maybe specifiable in the Taskfile.yaml (other Feature request.).
  • []string: Execute the process [0] with the given arguments [1..].

That makes the whole task definition much more sane.

The same is true for .CLI_ARGS which is a string, which is not helpful, it should be []strings]

@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: needs triage Waiting to be triaged by a maintainer.
Projects
None yet
Development

No branches or pull requests

2 participants