Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no check for receipt content #65

Open
c-bg opened this issue Aug 29, 2019 · 0 comments
Open

no check for receipt content #65

c-bg opened this issue Aug 29, 2019 · 0 comments

Comments

@c-bg
Copy link

c-bg commented Aug 29, 2019

Hi everyone,
First of all, thanks for this nice library.

I have two questions:

  1. If I see correctly, the connection Disconnect method only checks for whether the received next frame has the command RECEIPT, but does not check whether the received receipt's value is the same one as the sent receipt's one... shouldn't the code do that? Am I missing something here?

  2. Moreover, checking for whether the request contains a receipt and then checking the receipt is in almost all methods (e.g. in the connection Send method), but not in the Subscribe method. Why not? (note that this is slightly different than issue Support RECEIPT for SUBSCRIBE operations #40)

Thanks a lot for your answer in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant