Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: "Couldn't lanch browser" in Termux. #1147

Open
OXY2DEV opened this issue Nov 20, 2024 · 5 comments
Open

[bug]: "Couldn't lanch browser" in Termux. #1147

OXY2DEV opened this issue Nov 20, 2024 · 5 comments
Labels
question Questions related to rod

Comments

@OXY2DEV
Copy link

OXY2DEV commented Nov 20, 2024

I am trying to use vhs, and when running it I get this error.

could not launch browser: can't find a browser binary for your OS, the doc might help https://go-rod.github.io/#/compatibility?id=os : Not able to find a valid URL to download [https://storage.googleapis.com/chromium-browser-snapshots//1321438/ https://registry.npmmirror.com/-/binary/chromium-browser-snapshots//1321438/ https://playwright.azureedge.net/builds/chromium/1321438/chromium-linux-arm64.zip]
recording failed

I already have chromium-browser installed. I also have tried this inside proot(arch).

Am I missing something? Or is there some kind of bug thats causing this issue?

Version used:

  • Rod Version: v0.116.2
  • Vhs Version: 0.8
  • Termux Version: 0.119
  • Android Version: 13
@ysmood ysmood added the question Questions related to rod label Nov 20, 2024
@ysmood
Copy link
Member

ysmood commented Nov 20, 2024

You can specify the installed browser path manually:

u := launcher.New().Bin(path).MustLaunch()

@OXY2DEV
Copy link
Author

OXY2DEV commented Nov 20, 2024

That fixed the issue.

But this is weird. There was a merged PR that added Termux support.

And browser.go file seem to have chromium-browser in it. So, why wasn't it getting picked up?

@OXY2DEV
Copy link
Author

OXY2DEV commented Nov 20, 2024

Relevant line: browser.go#L222.

Relevant PR: #808

@ysmood
Copy link
Member

ysmood commented Nov 20, 2024

Maybe the for termux there will be multiple locations for the binary, could you make a PR to fix it?

@OXY2DEV
Copy link
Author

OXY2DEV commented Nov 20, 2024

The problem is, the PR should've solved the problem.

To check where chromium is I ran this,

> whereis chromium-browser
chromium-browser: /data/data/com.termux/files/usr/bin/chromium-browser

This path is already in here. So, why is it being skipped?

I thought it was an issue with my $PATH, but even after fixing that I still get that error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions related to rod
Projects
None yet
Development

No branches or pull requests

2 participants