Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.15: generated code does not pass go vet #245

Closed
uzzz opened this issue Sep 9, 2020 · 5 comments · Fixed by #266
Closed

Go 1.15: generated code does not pass go vet #245

uzzz opened this issue Sep 9, 2020 · 5 comments · Fixed by #266
Assignees
Labels
Milestone

Comments

@uzzz
Copy link

uzzz commented Sep 9, 2020

Describe the bug
With go 1.15 generated code that does not pass go test because of go vet warning.

To Reproduce

$ go version
go version go1.15 darwin/amd64

$ reform --version
v1.4.1

$ cat test.go 
package main


//go:generate reform

//reform:items
type item struct {
	ID string `reform:"id,pk"`
}

$ go generate ./...
$ go test ./...
./test_reform.go:107:10: conversion from int64 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

Expected behavior
No error on go vet

Additional context
golang/go#32479

@skamenetskiy
Copy link

I can see a pull request, when is it planned to go into release? go1.15 is currently broken 😞

@AlekSi AlekSi modified the milestones: v1.6.0, v1.5.0 Oct 9, 2020
@AlekSi
Copy link
Member

AlekSi commented Oct 9, 2020

Unfortunately, that PR is not enough. Workaround for now: go test -vet=atomic,bool,buildtags,errorsas,ifaceassert,nilfunc,printf

@AlekSi AlekSi pinned this issue Oct 9, 2020
@AlekSi AlekSi reopened this Dec 6, 2020
@AlekSi
Copy link
Member

AlekSi commented Dec 6, 2020

Please try v1.5.0-beta1

@AlekSi
Copy link
Member

AlekSi commented Dec 8, 2020

v1.5.0 released. See #269 for more in-depth explanation.

@uzzz
Copy link
Author

uzzz commented Dec 8, 2020

Yes, seems fine now, thanks for fixing it.

@AlekSi AlekSi closed this as completed Dec 8, 2020
@AlekSi AlekSi unpinned this issue Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants