Skip to content

Commit 476a4c4

Browse files
committed
chore: migrated calls to go-openapi/swag to the new API
Signed-off-by: Frederic BIDON <[email protected]>
1 parent 8de32b0 commit 476a4c4

File tree

9 files changed

+31
-32
lines changed

9 files changed

+31
-32
lines changed

bytestream.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"io"
2323
"reflect"
2424

25-
"github.com/go-openapi/swag"
25+
"github.com/go-openapi/swag/jsonutils"
2626
)
2727

2828
func defaultCloser() error { return nil }
@@ -206,7 +206,7 @@ func ByteStreamProducer(opts ...byteStreamOpt) Producer {
206206
return err
207207

208208
case t.Kind() == reflect.Struct || t.Kind() == reflect.Slice:
209-
b, err := swag.WriteJSON(data)
209+
b, err := jsonutils.WriteJSON(data)
210210
if err != nil {
211211
return err
212212
}

file.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414

1515
package runtime
1616

17-
import "github.com/go-openapi/swag"
17+
import "github.com/go-openapi/swag/fileutils"
1818

19-
type File = swag.File
19+
type File = fileutils.File

go.mod

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ require (
77
github.com/go-openapi/loads v0.22.0
88
github.com/go-openapi/spec v0.21.0
99
github.com/go-openapi/strfmt v0.23.0
10-
github.com/go-openapi/swag v0.24.1
10+
github.com/go-openapi/swag/fileutils v0.24.0
1111
github.com/go-openapi/validate v0.24.0
1212
github.com/opentracing/opentracing-go v1.2.0
1313
github.com/stretchr/testify v1.11.1
@@ -25,15 +25,15 @@ require (
2525
github.com/go-logr/stdr v1.2.2 // indirect
2626
github.com/go-openapi/jsonpointer v0.22.0 // indirect
2727
github.com/go-openapi/jsonreference v0.21.1 // indirect
28+
github.com/go-openapi/swag v0.24.1 // indirect
2829
github.com/go-openapi/swag/cmdutils v0.24.0 // indirect
29-
github.com/go-openapi/swag/conv v0.24.0 // indirect
30-
github.com/go-openapi/swag/fileutils v0.24.0 // indirect
30+
github.com/go-openapi/swag/conv v0.24.0
3131
github.com/go-openapi/swag/jsonname v0.24.0 // indirect
32-
github.com/go-openapi/swag/jsonutils v0.24.0 // indirect
32+
github.com/go-openapi/swag/jsonutils v0.24.0
3333
github.com/go-openapi/swag/loading v0.24.0 // indirect
3434
github.com/go-openapi/swag/mangling v0.24.0 // indirect
3535
github.com/go-openapi/swag/netutils v0.24.0 // indirect
36-
github.com/go-openapi/swag/stringutils v0.24.0 // indirect
36+
github.com/go-openapi/swag/stringutils v0.24.0
3737
github.com/go-openapi/swag/typeutils v0.24.0 // indirect
3838
github.com/go-openapi/swag/yamlutils v0.24.0 // indirect
3939
github.com/google/uuid v1.6.0 // indirect

middleware/parameter.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ import (
2424
"strconv"
2525

2626
"github.com/go-openapi/errors"
27+
"github.com/go-openapi/runtime"
2728
"github.com/go-openapi/spec"
2829
"github.com/go-openapi/strfmt"
29-
"github.com/go-openapi/swag"
30+
"github.com/go-openapi/swag/conv"
31+
"github.com/go-openapi/swag/stringutils"
3032
"github.com/go-openapi/validate"
31-
32-
"github.com/go-openapi/runtime"
3333
)
3434

3535
const defaultMaxMemory = 32 << 20
@@ -331,7 +331,7 @@ func (p *untypedParamBinder) setFieldValue(target reflect.Value, defaultValue in
331331
}
332332
return nil
333333
}
334-
b, err := swag.ConvertBool(data)
334+
b, err := conv.ConvertBool(data)
335335
if err != nil {
336336
return err
337337
}
@@ -455,7 +455,7 @@ func (p *untypedParamBinder) readFormattedSliceFieldValue(data string, target re
455455
return nil, true, nil
456456
}
457457

458-
return swag.SplitByFormat(data, p.parameter.CollectionFormat), false, nil
458+
return stringutils.SplitByFormat(data, p.parameter.CollectionFormat), false, nil
459459
}
460460

461461
func (p *untypedParamBinder) setSliceFieldValue(target reflect.Value, defaultValue interface{}, data []string, hasKey bool) error {

middleware/router.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
"github.com/go-openapi/runtime/security"
3232
"github.com/go-openapi/spec"
3333
"github.com/go-openapi/strfmt"
34-
"github.com/go-openapi/swag"
34+
"github.com/go-openapi/swag/stringutils"
3535
)
3636

3737
// RouteParam is a object to capture route params in a framework agnostic way.
@@ -460,11 +460,11 @@ func (d *defaultRouteBuilder) AddRoute(method, path string, operation *spec.Oper
460460
parameters := d.analyzer.ParamsFor(method, strings.TrimPrefix(path, bp))
461461

462462
// add API defaults if not part of the spec
463-
if defConsumes := d.api.DefaultConsumes(); defConsumes != "" && !swag.ContainsStringsCI(consumes, defConsumes) {
463+
if defConsumes := d.api.DefaultConsumes(); defConsumes != "" && !stringutils.ContainsStringsCI(consumes, defConsumes) {
464464
consumes = append(consumes, defConsumes)
465465
}
466466

467-
if defProduces := d.api.DefaultProduces(); defProduces != "" && !swag.ContainsStringsCI(produces, defProduces) {
467+
if defProduces := d.api.DefaultProduces(); defProduces != "" && !stringutils.ContainsStringsCI(produces, defProduces) {
468468
produces = append(produces, defProduces)
469469
}
470470

middleware/string_conversion_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323

2424
"github.com/go-openapi/spec"
2525
"github.com/go-openapi/strfmt"
26-
"github.com/go-openapi/swag"
26+
"github.com/go-openapi/swag/stringutils"
2727
"github.com/stretchr/testify/assert"
2828
"github.com/stretchr/testify/require"
2929
)
@@ -279,8 +279,8 @@ func TestSliceConversion(t *testing.T) {
279279
assert.Empty(t, tags)
280280
}
281281

282-
assert.Nil(t, swag.SplitByFormat("yada", "multi"))
283-
assert.Nil(t, swag.SplitByFormat("", ""))
282+
assert.Nil(t, stringutils.SplitByFormat("yada", "multi"))
283+
assert.Nil(t, stringutils.SplitByFormat("", ""))
284284

285285
categoriesField := val.FieldByName("Categories")
286286
binder := &untypedParamBinder{

middleware/validation.go

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,16 @@ import (
2020
"strings"
2121

2222
"github.com/go-openapi/errors"
23-
"github.com/go-openapi/swag"
24-
2523
"github.com/go-openapi/runtime"
24+
"github.com/go-openapi/swag/stringutils"
2625
)
2726

2827
type validation struct {
2928
context *Context
3029
result []error
3130
request *http.Request
3231
route *MatchedRoute
33-
bound map[string]interface{}
32+
bound map[string]any
3433
}
3534

3635
// ContentType validates the content type of a request
@@ -42,14 +41,14 @@ func validateContentType(allowed []string, actual string) error {
4241
if err != nil {
4342
return errors.InvalidContentType(actual, allowed)
4443
}
45-
if swag.ContainsStringsCI(allowed, mt) {
44+
if stringutils.ContainsStringsCI(allowed, mt) {
4645
return nil
4746
}
48-
if swag.ContainsStringsCI(allowed, "*/*") {
47+
if stringutils.ContainsStringsCI(allowed, "*/*") {
4948
return nil
5049
}
5150
parts := strings.Split(actual, "/")
52-
if len(parts) == 2 && swag.ContainsStringsCI(allowed, parts[0]+"/*") {
51+
if len(parts) == 2 && stringutils.ContainsStringsCI(allowed, parts[0]+"/*") {
5352
return nil
5453
}
5554
return errors.InvalidContentType(actual, allowed)
@@ -60,7 +59,7 @@ func validateRequest(ctx *Context, request *http.Request, route *MatchedRoute) *
6059
context: ctx,
6160
request: request,
6261
route: route,
63-
bound: make(map[string]interface{}),
62+
bound: make(map[string]any),
6463
}
6564
validate.debugLogf("validating request %s %s", request.Method, request.URL.EscapedPath())
6665

@@ -83,7 +82,7 @@ func (v *validation) parameters() {
8382
v.debugLogf("validating request parameters for %s %s", v.request.Method, v.request.URL.EscapedPath())
8483
if result := v.route.Binder.Bind(v.request, v.route.Params, v.route.Consumer, v.bound); result != nil {
8584
if result.Error() == "validation failure list" {
86-
for _, e := range result.(*errors.Validation).Value.([]interface{}) {
85+
for _, e := range result.(*errors.Validation).Value.([]any) {
8786
v.result = append(v.result, e.(error))
8887
}
8988
return

request.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"net/http"
2323
"strings"
2424

25-
"github.com/go-openapi/swag"
25+
"github.com/go-openapi/swag/stringutils"
2626
)
2727

2828
// CanHaveBody returns true if this method can have a body
@@ -145,5 +145,5 @@ func ReadSingleValue(values Gettable, name string) string {
145145
// ReadCollectionValue reads a collection value from a string data source
146146
func ReadCollectionValue(values Gettable, name, collectionFormat string) []string {
147147
v := ReadSingleValue(values, name)
148-
return swag.SplitByFormat(v, collectionFormat)
148+
return stringutils.SplitByFormat(v, collectionFormat)
149149
}

text.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"io"
2323
"reflect"
2424

25-
"github.com/go-openapi/swag"
25+
"github.com/go-openapi/swag/jsonutils"
2626
)
2727

2828
// TextConsumer creates a new text consumer
@@ -99,7 +99,7 @@ func TextProducer() Producer {
9999

100100
v := reflect.Indirect(reflect.ValueOf(data))
101101
if t := v.Type(); t.Kind() == reflect.Struct || t.Kind() == reflect.Slice {
102-
b, err := swag.WriteJSON(data)
102+
b, err := jsonutils.WriteJSON(data)
103103
if err != nil {
104104
return err
105105
}

0 commit comments

Comments
 (0)