Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tracing provider does not work #2802

Closed
Nomango opened this issue Apr 26, 2023 · 0 comments · Fixed by #2803
Closed

Custom tracing provider does not work #2802

Nomango opened this issue Apr 26, 2023 · 0 comments · Fixed by #2803
Labels
bug Something isn't working

Comments

@Nomango
Copy link
Contributor

Nomango commented Apr 26, 2023

What happened:

迁移 tracing 后端服务的时候想保证原来老的 tracing 暂时可用,但是 tracing middleware 默认使用了 global provider,导致 provider 的配置项不生效。

比如:

http.Middleware(
	tracing.Server(tracing.WithTracerProvider(provider1)),
	tracing.Server(tracing.WithTracerProvider(provider2)),
)

只有 provider2 会生效

What you expected to happen:

provider1 和 provider2 同时生效

How to reproduce it (as minimally and precisely as possible):

同上

Anything else we need to know?:

Environment:

  • Kratos version (use kratos -v): v2.5.3
  • Go version (use go version): v1.19
  • OS (e.g: cat /etc/os-release): macOS 13.3.1
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant