From af0df5531ad1c6f69cc73041840a17d4cc1df597 Mon Sep 17 00:00:00 2001 From: Ccheers <1048315650@qq.com> Date: Tue, 8 Oct 2024 11:30:37 +0800 Subject: [PATCH] feat(middleware/metrics): make DefaultSecondsHistogram simply (#3385) support middleware histograms, only need to call DefaultSecondsHistogram without registering DefaultSecondsHistogramView --- middleware/metrics/metrics.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/middleware/metrics/metrics.go b/middleware/metrics/metrics.go index becc31fa840..401c6377070 100644 --- a/middleware/metrics/metrics.go +++ b/middleware/metrics/metrics.go @@ -56,7 +56,11 @@ func DefaultRequestsCounter(meter metric.Meter, histogramName string) (metric.In // return metric.Float64Histogram for WithSeconds // suggest histogramName = _requests_seconds_bucket func DefaultSecondsHistogram(meter metric.Meter, histogramName string) (metric.Float64Histogram, error) { - return meter.Float64Histogram(histogramName, metric.WithUnit("s")) + return meter.Float64Histogram( + histogramName, + metric.WithUnit("s"), + metric.WithExplicitBucketBoundaries(0.005, 0.01, 0.025, 0.05, 0.1, 0.250, 0.5, 1), + ) } // DefaultSecondsHistogramView