Move to Standard library Context package

[GrimmKull]

Context is now a Standard Go library. It is the same code as golang.org/x/net/context.
The only thing that is missing is ctxhttp used in only for HTTP microservice clients.

I have a suggestion. To add a new branch to the main go-kit repository that uses the standard Context package and the ctxhttp implementation.

The code with these changes is available in GrimmKull fork in a separate 1.7context branch.

What do you guys think?

P.S.:

If anyone wants to use this before it gets moved to the main repository you can use vendoring.

Example:

govendor fetch "github.com/go-kit/kit/endpoint::github.com/GrimmKull/kit/[email protected]"

[peterbourgon]

Yep, I was waiting for 1.8 to drop and then make the switch in master. I'll start prepping for that now.

[willfaught]

Can't wait!

[ziyadparekh]

How do we use go-kit with go version 1.7.4 in the meantime ?

[groob]

@ziyadparekh you keep importing golang.org/x/net/context in your projects.

[ziyadparekh]

@groob Thanks for the quick reply.

The main error it throws is that it cant find the context http package inside the http transport package. And when i try to go get the context http package, it throws an error because its not found? Any ideas on what I can do to circumvent these errors?

Apologies for all the questions, but getting the right environment set up is a real pain.

Here is the error:

../../go-kit/kit/transport/http/client.go:8:2: cannot find package "golang.org/x/net/context/ctxhttp" in any of:
	/usr/local/go/src/golang.org/x/net/context/ctxhttp (from $GOROOT)
	/Users/zparekh/Go/src/golang.org/x/net/context/ctxhttp (from $GOPATH)

[groob]

Can you post the actual error getting instead of describing it?

The slack #go-kit channel might be a better place to debug this issue.

[ziyadparekh]

@groob Sorry about that. Posted the actual error in an edited version of the comment. I'll get myself set up on the Slack channel as well. In case you didnt see it, here is the error:

../../go-kit/kit/transport/http/client.go:8:2: cannot find package "golang.org/x/net/context/ctxhttp" in any of:
	/usr/local/go/src/golang.org/x/net/context/ctxhttp (from $GOROOT)
	/Users/zparekh/Go/src/golang.org/x/net/context/ctxhttp (from $GOPATH)

[willfaught]

go get -u golang.org/x/net/context/ctxhttp works for me. It doesn't work for you?

[groob]

We did a bit of an investigation on slack. It appears that you can run into some issues if you have $GOPATH/src/golang/org/x/net folder, but are missing the subdirectories go get starts to cause issues.

rm -rf go/src/golang.org/x/net/   

go get golang.org/x/net/context/ctxhttp

This resolves the issue for me, if anyone else runs into similar errors.

[peterbourgon]

Done.