Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some naming violates "Go Code Review Comments (Initialisms)" #419

Open
dqn opened this issue May 30, 2020 · 2 comments
Open

Some naming violates "Go Code Review Comments (Initialisms)" #419

dqn opened this issue May 30, 2020 · 2 comments

Comments

@dqn
Copy link

dqn commented May 30, 2020

This issue is a suggestion in line with golang's standard coding style.Resolving this issue will break backward compatibility and should be considered carefully.

CodeReviewComments · golang/go Wiki

For example, this naming is strange to me.
https://github.com/go-gorp/gorp/blob/master/db.go#L34

@nelsam
Copy link
Member

nelsam commented May 30, 2020

Yup. We can't change them without breaking our public API, and if we're going to do that, we might as well do the full rewrite we were planning way back when.

If you would like to start work on that, I'd be happy to chat about designs in gitter. Long story short: the next gorp (if we even continue to use this repo for it) needs to separate concerns much more than it does currently. But none of the maintainers use gorp in our daily life, so supporting it is weird. It's much harder to maintain a library when you don't use it (for dozens of reasons that I don't need to get in to here).

@dqn
Copy link
Author

dqn commented May 30, 2020

Thank you for replying.

As you say, the resolving this issue will be in the next gorp. When that time comes, consider the issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants