DbMap.Get() returns (nil, nil) if no row is found. Is this a bug?

[takumi-n]

Example:

package main

import (
	"database/sql"
	"fmt"

	_ "github.com/lib/pq"

	"gopkg.in/gorp.v2"
)

type Foo struct {
	ID  int64  `db:"id,primarykey"`
	Bar string `db:"bar"`
}

func main() {
	db, _ := sql.Open("postgres", "postgresql://...")

	dbMap := gorp.DbMap{Db: db, Dialect: gorp.PostgresDialect{}}
	dbMap.AddTableWithName(Foo{}, "foo").SetKeys(true, "ID")
	foo, err := dbMap.Get(Foo{}, 999) // There is no row corresponding to id = 999
	fmt.Println(foo, err) // The output will be nil, nil
}

DbMap.Get() returns (nil, nil) if no row is found.
I think it should returns (nil, error) if gorp cannot find any record.

Is this a bug?
or is there any reason?

[nelsam]

I don't know the history, but it does seem that this is explicitly handled: https://github.com/go-gorp/gorp/blob/master/gorp.go#L427-L429

@coopernurse it looks like you were the last to touch that explicit line. Is there any chance that you remember the context around why we're avoiding returning sql.ErrNoRows in dbmap.Get?

[MasterDimmy]

ensure your connection is ok.
this happens if connection failed