Skip to content

Never allow an empty password to validate (#9682) #9683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2020
Merged

Never allow an empty password to validate (#9682) #9683

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a74a65
Restore IsPasswordSet previous value
zeripath Jan 9, 2020
8ca7068
Update models/user.go
zeripath Jan 11, 2020
ba392d8
Merge branch 'release/v1.11' into backport-9682
lafriks Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ func (u *User) ValidatePassword(passwd string) bool {

// IsPasswordSet checks if the password is set or left empty
func (u *User) IsPasswordSet() bool {
return len(u.Passwd) > 0
return u.ValidatePassword("")
}

// UploadAvatar saves custom avatar for user.
Expand Down