Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 2, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 2, 2019
@codecov-io
Copy link

codecov-io commented Nov 2, 2019

Codecov Report

Merging #8785 into master will decrease coverage by 0.01%.
The diff coverage is 40.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8785      +/-   ##
==========================================
- Coverage   41.27%   41.25%   -0.02%     
==========================================
  Files         542      543       +1     
  Lines       69715    69766      +51     
==========================================
+ Hits        28774    28782       +8     
- Misses      37258    37291      +33     
- Partials     3683     3693      +10
Impacted Files Coverage Δ
services/issue/issue.go 23.68% <ø> (-6.21%) ⬇️
services/pull/pull.go 33.75% <100%> (-6.05%) ⬇️
modules/notification/notification.go 75.75% <100%> (+0.24%) ⬆️
modules/notification/webhook/webhook.go 40.18% <25.8%> (-1.1%) ⬇️
modules/notification/action/action.go 45.83% <45.83%> (ø)
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/process/manager.go 78.37% <0%> (-4.06%) ⬇️
modules/notification/base/null.go 65.21% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7971b05...0c82782. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2019
@zeripath zeripath merged commit 491887d into go-gitea:master Nov 3, 2019
@lunny lunny deleted the lunny/move_notifywatchers branch November 4, 2019 01:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants