From 3e93dad56cdbc16b2248e9aa1ffb0ecb36aa2881 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 15 Aug 2019 01:44:47 +0200 Subject: [PATCH 1/3] lfs/lock: round locked_at timestamp to second --- models/lfs_lock.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/lfs_lock.go b/models/lfs_lock.go index a27a6f495e3d..c38686796bba 100644 --- a/models/lfs_lock.go +++ b/models/lfs_lock.go @@ -56,7 +56,7 @@ func (l *LFSLock) APIFormat() *api.LFSLock { return &api.LFSLock{ ID: strconv.FormatInt(l.ID, 10), Path: l.Path, - LockedAt: l.Created, + LockedAt: l.Created.Round(time.Second), Owner: &api.LFSLockOwner{ Name: l.Owner.DisplayName(), }, From 3134fab57e681752caa0228b41662474d260d35d Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 15 Aug 2019 02:04:17 +0200 Subject: [PATCH 2/3] test returned locked_at values --- integrations/api_repo_lfs_locks_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/integrations/api_repo_lfs_locks_test.go b/integrations/api_repo_lfs_locks_test.go index 657933dd5c35..d73ed54bfa9a 100644 --- a/integrations/api_repo_lfs_locks_test.go +++ b/integrations/api_repo_lfs_locks_test.go @@ -104,8 +104,11 @@ func TestAPILFSLocksLogged(t *testing.T) { req := NewRequestWithJSON(t, "POST", fmt.Sprintf("/%s.git/info/lfs/locks", test.repo.FullName()), map[string]string{"path": test.path}) req.Header.Set("Accept", "application/vnd.git-lfs+json") req.Header.Set("Content-Type", "application/vnd.git-lfs+json") - session.MakeRequest(t, req, test.httpResult) + resp := session.MakeRequest(t, req, test.httpResult) if len(test.addTime) > 0 { + var lfsLock api.LFSLockResponse + DecodeJSON(t, resp, &lfsLock) + assert.EqualValues(t, lfsLock.Lock.LockedAt.Round(time.Second).Format(time.RFC3339Nano), lfsLock.Lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second for _, id := range test.addTime { resultsTests[id].locksTimes = append(resultsTests[id].locksTimes, time.Now()) } @@ -124,6 +127,7 @@ func TestAPILFSLocksLogged(t *testing.T) { for i, lock := range lfsLocks.Locks { assert.EqualValues(t, test.locksOwners[i].DisplayName(), lock.Owner.Name) assert.WithinDuration(t, test.locksTimes[i], lock.LockedAt, 3*time.Second) + assert.EqualValues(t, lock.LockedAt.Round(time.Second).Format(time.RFC3339Nano), lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second } req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/%s.git/info/lfs/locks/verify", test.repo.FullName()), map[string]string{}) From c352bfc5d5023489644ae26bb3fcc74854491260 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 15 Aug 2019 02:10:36 +0200 Subject: [PATCH 3/3] tests: use time RFC3339 --- integrations/api_repo_lfs_locks_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/integrations/api_repo_lfs_locks_test.go b/integrations/api_repo_lfs_locks_test.go index d73ed54bfa9a..6c0aeb115295 100644 --- a/integrations/api_repo_lfs_locks_test.go +++ b/integrations/api_repo_lfs_locks_test.go @@ -108,7 +108,7 @@ func TestAPILFSLocksLogged(t *testing.T) { if len(test.addTime) > 0 { var lfsLock api.LFSLockResponse DecodeJSON(t, resp, &lfsLock) - assert.EqualValues(t, lfsLock.Lock.LockedAt.Round(time.Second).Format(time.RFC3339Nano), lfsLock.Lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second + assert.EqualValues(t, lfsLock.Lock.LockedAt.Format(time.RFC3339), lfsLock.Lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second for _, id := range test.addTime { resultsTests[id].locksTimes = append(resultsTests[id].locksTimes, time.Now()) } @@ -127,7 +127,7 @@ func TestAPILFSLocksLogged(t *testing.T) { for i, lock := range lfsLocks.Locks { assert.EqualValues(t, test.locksOwners[i].DisplayName(), lock.Owner.Name) assert.WithinDuration(t, test.locksTimes[i], lock.LockedAt, 3*time.Second) - assert.EqualValues(t, lock.LockedAt.Round(time.Second).Format(time.RFC3339Nano), lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second + assert.EqualValues(t, lock.LockedAt.Format(time.RFC3339), lock.LockedAt.Format(time.RFC3339Nano)) //locked at should be rounded to second } req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/%s.git/info/lfs/locks/verify", test.repo.FullName()), map[string]string{})