From a11b01ab5bb4621d5f01a5a0fc8c65cd18781cb0 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 27 Apr 2026 08:40:22 +0800 Subject: [PATCH 1/4] fix --- templates/org/home.tmpl | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl index 7132743d0c889..b58bb4109c3da 100644 --- a/templates/org/home.tmpl +++ b/templates/org/home.tmpl @@ -55,11 +55,12 @@ {{end}} {{if .NumMembers}} -

- {{ctx.Locale.Tr "org.members"}} +

+ {{ctx.Locale.Tr "org.members"}} {{.NumMembers}} {{svg "octicon-chevron-right"}}

-
+ {{/* gap 8px below is specially chosen to make sure a full line of avatars can exactly fit the segment width */}} +
{{range $memberUser := .OrgOverviewMembers}} {{if or $.IsOrganizationMember (call $.IsPublicMember $memberUser.ID)}} {{template "shared/user/avatarlink" dict "user" $memberUser "size" 32 "tooltip" true}} @@ -68,11 +69,12 @@
{{end}} {{if .IsOrganizationMember}} -
- {{ctx.Locale.Tr "org.teams"}} +
+ {{ctx.Locale.Tr "org.teams"}} {{.Org.NumTeams}} {{svg "octicon-chevron-right"}}
-
+
+
{{range .OrgOverviewTeams}}
{{.Name}} @@ -82,6 +84,7 @@

{{end}} +
{{if .IsOrganizationOwner}}
From 897875318fdd2619580ec14e93646609d4313a14 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 27 Apr 2026 14:56:12 +0800 Subject: [PATCH 2/4] clean up --- templates/org/header.tmpl | 36 +++++++++++++++++++-------------- templates/org/home.tmpl | 6 +++--- templates/org/team/sidebar.tmpl | 20 +++++++++--------- web_src/css/index.css | 1 - web_src/css/org.css | 32 ----------------------------- web_src/css/shared/repoorg.css | 18 ----------------- 6 files changed, 34 insertions(+), 79 deletions(-) delete mode 100644 web_src/css/shared/repoorg.css diff --git a/templates/org/header.tmpl b/templates/org/header.tmpl index 83ae95a1ae790..4f9e54b610924 100644 --- a/templates/org/header.tmpl +++ b/templates/org/header.tmpl @@ -1,13 +1,13 @@ -
- {{ctx.AvatarUtils.Avatar .Org 100 "org-avatar"}} -
-
- {{.Org.DisplayName}} - +
+
{{ctx.AvatarUtils.Avatar .Org 100}}
+
+
+
+ {{.Org.DisplayName}} {{if .Org.Visibility.IsLimited}}{{ctx.Locale.Tr "org.settings.visibility.limited_shortname"}}{{end}} {{if .Org.Visibility.IsPrivate}}{{ctx.Locale.Tr "org.settings.visibility.private_shortname"}}{{end}} - - +
+
{{if .EnableFeed}} {{svg "octicon-rss" 24}} @@ -16,14 +16,20 @@ {{if .IsSigned}} {{template "org/follow_unfollow" .}} {{end}} - +
- {{if .RenderedDescription}}
{{.RenderedDescription}}
{{end}} -
- {{if .Org.Location}}
{{svg "octicon-location"}} {{.Org.Location}}
{{end}} - {{if .Org.Website}}
{{svg "octicon-link"}} {{.Org.Website}}
{{end}} - {{if .IsSigned}} - {{if .Org.Email}}
{{svg "octicon-mail"}} {{.Org.Email}}
{{end}} + {{if .RenderedDescription}} +
{{.RenderedDescription}}
+ {{end}} +
+ {{if .Org.Location}} +
{{svg "octicon-location"}} {{.Org.Location}}
+ {{end}} + {{if .Org.Website}} +
{{svg "octicon-link"}} {{.Org.Website}}
+ {{end}} + {{if and .IsSigned .Org.Email}} +
{{svg "octicon-mail"}} {{.Org.Email}}
{{end}}
diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl index b58bb4109c3da..63f88e7dcdbf9 100644 --- a/templates/org/home.tmpl +++ b/templates/org/home.tmpl @@ -74,10 +74,10 @@ {{.Org.NumTeams}} {{svg "octicon-chevron-right"}}
-
+
{{range .OrgOverviewTeams}} -
- {{.Name}} +
+ {{.Name}}

{{.NumMembers}} {{ctx.Locale.Tr "org.lower_members"}} ยท {{.NumRepos}} {{ctx.Locale.Tr "org.lower_repositories"}} diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl index 1487c280dee68..230d38cc84cd4 100644 --- a/templates/org/team/sidebar.tmpl +++ b/templates/org/team/sidebar.tmpl @@ -15,21 +15,21 @@ {{end}}

-
-
+ +
{{if .Team.Description}} {{.Team.Description}} {{else}} {{ctx.Locale.Tr "org.teams.no_desc"}} {{end}}
- {{if eq .Team.LowerName "owners"}} -
+ +
+ {{/* TODO: old indent is kept to make diff changes minimal, can be reformated in the future */}} + {{if eq .Team.LowerName "owners"}}

{{ctx.Locale.Tr "org.teams.owners_permission_desc"}}

{{ctx.Locale.Tr "org.teams.owners_permission_suggestion"}}

-
- {{else}} -
+ {{else}}

{{ctx.Locale.Tr "org.team_access_desc"}}

    {{if .Team.IncludesAllRepositories}} @@ -75,9 +75,9 @@ {{end}} -
- {{end}} -
+ {{end}} +
+ {{if .IsOrganizationOwner}}
{{svg "octicon-gear"}} {{ctx.Locale.Tr "org.teams.settings"}} diff --git a/web_src/css/index.css b/web_src/css/index.css index c23e3e1c19ff8..d7f57e324b097 100644 --- a/web_src/css/index.css +++ b/web_src/css/index.css @@ -37,7 +37,6 @@ @import "./shared/flex-list.css"; @import "./shared/milestone.css"; -@import "./shared/repoorg.css"; @import "./shared/settings.css"; @import "./features/dropzone.css"; diff --git a/web_src/css/org.css b/web_src/css/org.css index b54a21ac6e1e0..fd7ea733c352e 100644 --- a/web_src/css/org.css +++ b/web_src/css/org.css @@ -1,23 +1,3 @@ -.organization .head .ui.header .ui.right { - margin-top: 5px; -} - -.page-content.organization .org-avatar { - margin-right: 15px; -} - -.page-content.organization #org-info .ui.header { - display: flex; - align-items: center; - font-size: 36px; - margin-bottom: 0; -} - -.page-content.organization #org-info .desc { - font-size: 16px; - margin-bottom: 10px; -} - .page-content.organization .team-item-box > .team-item-header { min-height: 50px; /* the header sometimes contains a mini button, sometimes not, so we set a min-height to make sure the layout is consistent */ } @@ -35,15 +15,3 @@ width: 100%; height: 100%; } - -.organization.teams .detail .item { - padding: 10px 15px; -} - -.organization.teams .detail .item:not(:last-child) { - border-bottom: 1px solid var(--color-secondary); -} - -.org-team-navbar .active.item { - background: var(--color-box-body) !important; -} diff --git a/web_src/css/shared/repoorg.css b/web_src/css/shared/repoorg.css deleted file mode 100644 index 5573ae47b81ec..0000000000000 --- a/web_src/css/shared/repoorg.css +++ /dev/null @@ -1,18 +0,0 @@ -.repository .head .ui.header .text, -.organization .head .ui.header .text { - vertical-align: middle; - font-size: 1.6rem; - margin-left: 15px; -} - -.repository .ui.tabs.container, -.organization .ui.tabs.container { - margin-top: 14px; - margin-bottom: 0; -} - -.repository .head .ui.header .org-visibility .label, -.organization .head .ui.header .org-visibility .label { - margin-left: 5px; - margin-top: 5px; -} From 63c32bae42402e9f82894bc9e3eab82221245463 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 27 Apr 2026 15:10:46 +0800 Subject: [PATCH 3/4] clean up --- routers/web/org/teams.go | 2 ++ templates/org/team/invite.tmpl | 14 +++++--------- web_src/css/org.css | 5 ----- 3 files changed, 7 insertions(+), 14 deletions(-) diff --git a/routers/web/org/teams.go b/routers/web/org/teams.go index 10803c9fbf5fb..731247829905e 100644 --- a/routers/web/org/teams.go +++ b/routers/web/org/teams.go @@ -609,6 +609,8 @@ func DeleteTeam(ctx *context.Context) { // TeamInvite renders the team invite page func TeamInvite(ctx *context.Context) { invite, org, team, inviter, err := getTeamInviteFromContext(ctx) + // TODO: to quickly debug the UI, can uncomment this (don't worry, it won't pass CI lint) + // invite, org, team, inviter, err = &org_model.TeamInvite{}, &org_model.Organization{}, &org_model.Team{}, ctx.Doer, nil if err != nil { if org_model.IsErrTeamInviteNotFound(err) { ctx.NotFound(err) diff --git a/templates/org/team/invite.tmpl b/templates/org/team/invite.tmpl index 14a97ae659d0d..f33d5b22f4660 100644 --- a/templates/org/team/invite.tmpl +++ b/templates/org/team/invite.tmpl @@ -1,18 +1,14 @@ {{template "base/head" .}} -
+
{{template "base/alert" .}} -
-
- {{ctx.AvatarUtils.Avatar .Organization 140}} -
-
+
+
+
{{ctx.AvatarUtils.Avatar .Organization 140}}
{{ctx.Locale.Tr "org.teams.invite.title" .Team.Name .Organization.Name}}
{{ctx.Locale.Tr "org.teams.invite.by" .Inviter.Name}}
{{ctx.Locale.Tr "org.teams.invite.description"}}
-
-
-
+
diff --git a/web_src/css/org.css b/web_src/css/org.css index fd7ea733c352e..6de9ebd51e7a3 100644 --- a/web_src/css/org.css +++ b/web_src/css/org.css @@ -10,8 +10,3 @@ white-space: nowrap; color: var(--color-text-light-3); } - -.organization.invite .ui.avatar { - width: 100%; - height: 100%; -} From 05a16209b898b373828f4eeaaa09d6c168ad5401 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 27 Apr 2026 21:00:33 +0800 Subject: [PATCH 4/4] remove dead css classes, fix comment --- templates/org/home.tmpl | 2 +- templates/org/team/invite.tmpl | 6 +++--- templates/org/team/sidebar.tmpl | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/templates/org/home.tmpl b/templates/org/home.tmpl index 63f88e7dcdbf9..12b41c3e94267 100644 --- a/templates/org/home.tmpl +++ b/templates/org/home.tmpl @@ -59,7 +59,7 @@ {{ctx.Locale.Tr "org.members"}} {{.NumMembers}} {{svg "octicon-chevron-right"}} - {{/* gap 8px below is specially chosen to make sure a full line of avatars can exactly fit the segment width */}} + {{/* gap 8px below is specifically chosen to make sure a full line of avatars can exactly fit the segment width */}}
{{range $memberUser := .OrgOverviewMembers}} {{if or $.IsOrganizationMember (call $.IsPublicMember $memberUser.ID)}} diff --git a/templates/org/team/invite.tmpl b/templates/org/team/invite.tmpl index f33d5b22f4660..d591414efc7d0 100644 --- a/templates/org/team/invite.tmpl +++ b/templates/org/team/invite.tmpl @@ -5,9 +5,9 @@
{{ctx.AvatarUtils.Avatar .Organization 140}}
-
{{ctx.Locale.Tr "org.teams.invite.title" .Team.Name .Organization.Name}}
-
{{ctx.Locale.Tr "org.teams.invite.by" .Inviter.Name}}
-
{{ctx.Locale.Tr "org.teams.invite.description"}}
+
{{ctx.Locale.Tr "org.teams.invite.title" .Team.Name .Organization.Name}}
+
{{ctx.Locale.Tr "org.teams.invite.by" .Inviter.Name}}
+
{{ctx.Locale.Tr "org.teams.invite.description"}}
diff --git a/templates/org/team/sidebar.tmpl b/templates/org/team/sidebar.tmpl index 230d38cc84cd4..1036e886da77a 100644 --- a/templates/org/team/sidebar.tmpl +++ b/templates/org/team/sidebar.tmpl @@ -25,7 +25,7 @@
- {{/* TODO: old indent is kept to make diff changes minimal, can be reformated in the future */}} + {{/* TODO: old indent is kept to make diff changes minimal, can be reformatted in the future */}} {{if eq .Team.LowerName "owners"}}

{{ctx.Locale.Tr "org.teams.owners_permission_desc"}}

{{ctx.Locale.Tr "org.teams.owners_permission_suggestion"}}