From 58b19dbbeb3979081c01a8ee0fa68d24f4a432f3 Mon Sep 17 00:00:00 2001 From: silverwind Date: Thu, 23 Apr 2026 18:35:03 +0200 Subject: [PATCH] CI: drop -coverprofile from unit-tests to enable Go test result cache The test-unit job invoked 'make unit-test-coverage', which passes -coverprofile to 'go test'. That flag is not in Go's cacheable-flags allowlist, so it silently disables the test result cache for every unit-test package on every run. The coverage.out output is unused: no workflow calls 'make coverage' (its only consumer), and no codecov/coveralls integration exists. The matching test-mysql job comment ('at the moment, no coverage is really handled') confirms coverage has been dead for some time. Switch to 'make test-backend', preserving the 20m timeout via GOTESTFLAGS. On warm runs with an intact build cache, unchanged unit-test packages are now skipped entirely. Co-Authored-By: Claude (Opus 4.7) --- .github/workflows/pull-db-tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-db-tests.yml b/.github/workflows/pull-db-tests.yml index d168c2ecc5fab..49cc7b6e76b9d 100644 --- a/.github/workflows/pull-db-tests.yml +++ b/.github/workflows/pull-db-tests.yml @@ -142,16 +142,18 @@ jobs: env: TAGS: bindata - name: unit-tests - run: make unit-test-coverage test-check + run: make test-backend test-check env: TAGS: bindata RACE_ENABLED: true + GOTESTFLAGS: -timeout=20m GITHUB_READ_TOKEN: ${{ secrets.GITHUB_READ_TOKEN }} - name: unit-tests-gogit - run: GOEXPERIMENT='' make unit-test-coverage test-check + run: GOEXPERIMENT='' make test-backend test-check env: TAGS: bindata gogit RACE_ENABLED: true + GOTESTFLAGS: -timeout=20m GITHUB_READ_TOKEN: ${{ secrets.GITHUB_READ_TOKEN }} test-mysql: