Skip to content

Fix some trivial problems (#36336)#36337

Merged
lafriks merged 1 commit intogo-gitea:release/v1.25from
wxiaoguang:fix-various-1.25
Jan 9, 2026
Merged

Fix some trivial problems (#36336)#36337
lafriks merged 1 commit intogo-gitea:release/v1.25from
wxiaoguang:fix-various-1.25

Conversation

@wxiaoguang
Copy link
Contributor

Partially backport #36336

  1. correctly parse git protocol's "OldCommit NewCommit RefName" line, it should be explicitly split by space
  2. trim space for the "commit status context name" to follow the same behavior of git_model.NewCommitStatus

@GiteaBot GiteaBot added this to the 1.25.4 milestone Jan 9, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2026
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Jan 9, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2026
@lafriks lafriks merged commit 83ce45b into go-gitea:release/v1.25 Jan 9, 2026
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-various-1.25 branch January 9, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants