Skip to content

Fix api releases attachments wrong URL #26175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix api releases attachments wrong URL #26175

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eabce19
fix bug
lunny Jul 27, 2023
1858d7b
Fix bug
lunny Jul 27, 2023
ca5fe01
Fix test
lunny Jul 27, 2023
0ade557
Merge branch 'main' into lunny/fix_api_releases
lunny Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions services/convert/attachment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ func WebAssetDownloadURL(repo *repo_model.Repository, attach *repo_model.Attachm
}

func APIAssetDownloadURL(repo *repo_model.Repository, attach *repo_model.Attachment) string {
if attach.CustomDownloadURL != "" {
return attach.CustomDownloadURL
}

// /repos/{owner}/{repo}/releases/{id}/assets/{attachment_id}
return setting.AppURL + "api/repos/" + repo.FullName() + "/releases/" + strconv.FormatInt(attach.ReleaseID, 10) + "/assets/" + strconv.FormatInt(attach.ID, 10)
}
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/api_releases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ func TestAPIListReleases(t *testing.T) {
case 1:
assert.False(t, release.IsDraft)
assert.False(t, release.IsPrerelease)
assert.Len(t, release.Attachments, 1)
assert.EqualValues(t, "http://localhost:3003/api/repos/user2/repo1/releases/1/assets/9", release.Attachments[0].DownloadURL)
case 4:
assert.True(t, release.IsDraft)
assert.False(t, release.IsPrerelease)
Expand Down