Skip to content

Introduce path Clean/Join helper functions, partially backport&refactor (#23495) #23607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

Introduce path Clean/Join helper functions, partially backport&refactor (#23495) #23607

merged 2 commits into from
Mar 22, 2023

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 21, 2023 •
edited
Loading

Backport #23495, partially backport&refactor

The modules/options files are just copied from 1.20 to 1.19

@wxiaoguang wxiaoguang force-pushed the fix-clean-path-backport branch 6 times, most recently from 032b91b to 177559d Compare March 21, 2023 13:41
@wxiaoguang wxiaoguang force-pushed the fix-clean-path-backport branch from 177559d to 0b2d6f0 Compare March 21, 2023 13:55
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 22, 2023

This PR has been synchronized with the #23495 .

To void introducing unnecessary changes, this PR only introduces the helper functions and refactor the modules/options package.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2023
@wxiaoguang wxiaoguang mentioned this pull request Mar 22, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2023
@lunny lunny added the type/bug label Mar 22, 2023
@lunny lunny added this to the 1.19.1 milestone Mar 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 22, 2023
@lunny lunny merged commit 774b37b into go-gitea:release/v1.19 Mar 22, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 22, 2023
@wxiaoguang wxiaoguang deleted the fix-clean-path-backport branch March 23, 2023 13:47
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.19.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @delvh @GiteaBot