Skip to content

Enable @<user>- completion popup on the release description textarea #22359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Enable @<user>- completion popup on the release description textarea #22359

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b953d9
Enable "mention <x>"- popup on the release description textarea
delvh Jan 6, 2023
88494c1
load Assignees for mention
a1012112796 Jan 11, 2023
927cefc
Load assignees to be able to mention them
a1012112796 Jan 31, 2023
4bc19c7
Merge branch 'main' into feature/mentioning-on-release-description
delvh Jan 31, 2023
2118fe9
Merge branch 'main' into feature/mentioning-on-release-description
zeripath Feb 1, 2023
bcb3275
Merge branch 'main' into feature/mentioning-on-release-description
lunny Feb 1, 2023
fba5081
Merge branch 'main' into feature/mentioning-on-release-description
jolheiser Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web_src/js/features/repo-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ export function initRepoRelease() {
export function initRepoReleaseEditor() {
const $editor = $('.repository.new.release .content-editor');
if ($editor.length === 0) {
return false;
return;
Copy link
Member

@a1012112796 a1012112796 Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

@delvh delvh Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally removed an unused return value.

Because the rest of the function does not return anything, and the caller of the function does not use the returned value.

}

(async () => {
const $textarea = $editor.find('textarea');
await attachTribute($textarea.get(), {mentions: false, emoji: true});
await attachTribute($textarea.get(), {mentions: true, emoji: true});
const easyMDE = await createCommentEasyMDE($textarea);
initCompMarkupContentPreviewTab($editor);
const $dropzone = $editor.parent().find('.dropzone');
Expand Down