Skip to content

Fix user visible check #21210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Fix user visible check #21210

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d216367
Fix visible check
KN4CK3R Sep 19, 2022
e32a20c
Merge branch 'main' into patch-2
6543 Sep 19, 2022
218f7d9
Add tests.
KN4CK3R Sep 19, 2022
fd9fa93
Fix consistency.
KN4CK3R Sep 19, 2022
c7174c6
Fix test.
KN4CK3R Sep 19, 2022
73ede98
Merge branch 'main' into patch-2
6543 Sep 19, 2022
69bd714
Merge branch 'main' into patch-2
lunny Sep 20, 2022
5109170
Fix access fixtures.
KN4CK3R Sep 20, 2022
7bc81b4
newline
KN4CK3R Sep 20, 2022
a0041b6
And another newline
KN4CK3R Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion models/user/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,9 @@ func IsUserVisibleToViewer(ctx context.Context, u, viewer *User) bool {
if viewer == nil || viewer.IsRestricted {
return false
}
if viewer.ID == u.ID {
return true
}

// If they follow - they see each over
follower := IsFollowing(u.ID, viewer.ID)
Expand All @@ -1306,7 +1309,7 @@ func IsUserVisibleToViewer(ctx context.Context, u, viewer *User) bool {
return false
}

if count < 0 {
if count == 0 {
// No common organization
return false
}
Expand Down