Skip to content

Unify repo settings & show better error #19828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wxiaoguang merged 9 commits into from
Jun 12, 2022
Merged

Unify repo settings & show better error #19828

wxiaoguang merged 9 commits into from
Jun 12, 2022

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented May 28, 2022

  • Move the minimal required context data into a middleware, this is so when SettingsPost renders the settings template + error, it will actually shows the correct data(e.g. actually renders the mirror section).
  • Include the host when rendering URL errors.
    image

@Gusted Gusted added this to the 1.17.0 milestone May 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2022
lunny
lunny reviewed Jun 5, 2022
View reviewed changes
@Gusted Gusted mentioned this pull request Jun 5, 2022
Merged
zeripath
zeripath reviewed Jun 5, 2022
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2022
zeripath
zeripath reviewed Jun 5, 2022
View reviewed changes
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2022
@wxiaoguang wxiaoguang merged commit edf1420 into go-gitea:main Jun 12, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 12, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
f162c40 
* giteaoffical/main:
  Fix signal loop in graceful manager (go-gitea#19943)
  Prettify number of issues (go-gitea#17760)
  Improve file header on mobile (go-gitea#19945)
  Unify repo settings & show better error (go-gitea#19828)
  [skip ci] Updated translations via Crowdin
  fixed comment typo (go-gitea#19944)
  Auto merge pull requests when all checks succeeded via WebUI (go-gitea#19648)
  Fix some mirror bugs (go-gitea#18649)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Unify repo settings & show better error (go-gitea#19828)
f3715e5 
* Unify context data
* Actually show invalid url in error
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+2 more reviewers

@zeripath zeripath zeripath approved these changes

@singuliere singuliere singuliere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Gusted @lunny @zeripath @singuliere @wxiaoguang @GiteaBot