User keypairs and HTTP signatures for ActivityPub federation using go-ap #19133

ghost · 2022-03-18T22:57:44Z

This implements a few components of the ActivityPub protocol using the go-ap library. This includes an /activitypub and /activitypub/user endpoint for the API, ActivityPub-specific information in the /.well-known/webfinger endpoint, and middleware for HTTP signatures. It does not do much but it is an essential building block for ActivityPub federation.

depend on Use Golang 1.18 for Gitea 1.17 release #19918

go get github.com/go-fed/activity/streams@master go get github.com/go-fed/activity/pub@master go get github.com/go-fed/httpsig@master

Return informations regarding a Person (as defined in ActivityStreams https://www.w3.org/TR/activitystreams-vocabulary/#dfn-person). Refs: #14186 Signed-off-by: Loïc Dachary <[email protected]>

Refs: #14186 Signed-off-by: Loïc Dachary <[email protected]>

Signed-off-by: Loïc Dachary <[email protected]>

integrations/api_activitypub_person_test.go

Signed-off-by: Anthony Wang <[email protected]>

integrations/api_activitypub_person_test.go

Signed-off-by: Anthony Wang <[email protected]>

Gusted

Overall looking good. Code flow looks good to me, we might want to add some more comments here and there because I'm still scratching my head at some sections of the code, of what's actually doing.

routers/api/v1/api.go

routers/api/v1/activitypub/reqsignature.go

routers/api/v1/activitypub/person.go

modules/activitypub/hack_16834.go

Signed-off-by: Anthony Wang <[email protected]>

ghost · 2022-03-24T23:50:31Z

This PR adds the large go-fed library which increases the Gitea binary size from 80 MB to 103 MB. I originally created #19104 to discuss ways to deal with this addition, but we can also discuss it here.

Gusted · 2022-03-25T16:16:48Z

This PR adds the large go-fed library which increases the Gitea binary size from 80 MB to 103 MB. I originally created #19104 to discuss ways to deal with this addition, but we can also discuss it here.

That's measurably bigger. Of course it would be nice if go-fed was able to simplify code to reduce the binary size. Possible solution, given the nature of this is to introduce build tags within gitea, such that go-fed won't compile if one doesn't want to use federation.

Signed-off-by: Anthony Wang <[email protected]>

6543

at least add it ...

custom/conf/app.example.ini

docs/content/doc/advanced/config-cheat-sheet.en-us.md

modules/setting/federation.go

modules/activitypub/client.go

ghost · 2022-06-18T17:30:48Z

Sorry for the force-push: I think it's because https://github.com/Ta180m/gitea is a push mirror of https://gitea.com/Ta180m/gitea and a commit on the GitHub repo was overwritten when gitea.com synchronized the mirror.

6543 · 2022-06-18T18:28:46Z

to bad ... I was just going to merge this ...

ghost · 2022-06-18T19:22:18Z

Sorry for the force-push: I think it's because https://github.com/Ta180m/gitea is a push mirror of https://gitea.com/Ta180m/gitea and a commit on the GitHub repo was overwritten when gitea.com synchronized the mirror.

@6543 I don't think there was anything important overwritten so it should be OK to merge now.

delvh

I only skimmed through it because it seems to get merged soon, but I found a few things:

routers/api/v1/swagger/activitypub.go

routers/web/webfinger.go

delvh · 2022-06-18T21:04:14Z

modules/activitypub/client.go

+// NewClient function
+func NewClient(user *user_model.User, pubID string) (c *Client, err error) {
+	if err = containsRequiredHTTPHeaders(http.MethodGet, setting.Federation.GetHeaders); err != nil {
+		return


Given that there is currently a PR that attempts to get rid of naked returns, I think you should convert them.
Everywhere you added them.

routers/api/v1/activitypub/reqsignature.go

routers/api/v1/activitypub/person.go

…nger.go

6543 · 2022-06-19T05:22:49Z

🚀

routers/api/v1/activitypub/person.go

Loïc Dachary added 7 commits March 18, 2022 17:33

go.mod: add go-fed/{httpsig,activity/pub,activity/streams} dependency

f2db473

go get github.com/go-fed/activity/streams@master go get github.com/go-fed/activity/pub@master go get github.com/go-fed/httpsig@master

activitypub: implement /api/v1/activitypub/user/{username} (#14186)

4951af4

Return informations regarding a Person (as defined in ActivityStreams https://www.w3.org/TR/activitystreams-vocabulary/#dfn-person). Refs: #14186 Signed-off-by: Loïc Dachary <[email protected]>

activitypub: add the public key to Person (#14186)

678a56f

Refs: #14186 Signed-off-by: Loïc Dachary <[email protected]>

activitypub: go-fed conformant Clock instance

e8907c3

Signed-off-by: Loïc Dachary <[email protected]>

activitypub: signing http client

15c1f62

Signed-off-by: Loïc Dachary <[email protected]>

activitypub: implement the ReqSignature middleware

97fedf2

Signed-off-by: Loïc Dachary <[email protected]>

activitypub: hack_16834

b342241

Signed-off-by: Loïc Dachary <[email protected]>

lunny reviewed Mar 19, 2022

View reviewed changes

integrations/api_activitypub_person_test.go Outdated Show resolved Hide resolved

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2022

lunny reviewed Mar 19, 2022

View reviewed changes

integrations/api_activitypub_person_test.go Outdated Show resolved Hide resolved

lunny reviewed Mar 19, 2022

View reviewed changes

integrations/api_activitypub_person_test.go Show resolved Hide resolved

lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/federation labels Mar 19, 2022

Gusted added this to the 1.17.0 milestone Mar 19, 2022

Anthony Wang added 2 commits March 19, 2022 08:54

Fix CI checks-backend errors with go mod tidy

2a8864f

Signed-off-by: Anthony Wang <[email protected]>

Change 2021 to 2022, properly format package imports

b480c52

Signed-off-by: Anthony Wang <[email protected]>

Gusted reviewed Mar 19, 2022

View reviewed changes

Anthony Wang added 5 commits March 19, 2022 09:14

Run make fmt and make generate-swagger

f9e33d9

Signed-off-by: Anthony Wang <[email protected]>

Use Gitea JSON library, add assert for pkp

ea4129e

Signed-off-by: Anthony Wang <[email protected]>

Run make fmt again, fix err var redeclaration

456ed42

Signed-off-by: Anthony Wang <[email protected]>

Remove LogSQL from ActivityPub person test

d75809a

Signed-off-by: Anthony Wang <[email protected]>

Assert if json.Unmarshal succeeds

ebef769

Signed-off-by: Anthony Wang <[email protected]>

ghost requested a review from Gusted March 21, 2022 02:41

Gusted reviewed Mar 23, 2022

View reviewed changes

Cleanup, handle invalid usernames for ActivityPub person GET request

46973f9

Signed-off-by: Anthony Wang <[email protected]>

ghost mentioned this pull request Mar 25, 2022

Draft: Add the go-fed dependency needed for ActivityPub federation #19104

Closed

Rename hack_16834 to user_settings

3ed4a71

Signed-off-by: Anthony Wang <[email protected]>

ghost requested a review from Gusted March 26, 2022 01:50

6543 reviewed Jun 17, 2022

View reviewed changes

custom/conf/app.example.ini Outdated Show resolved Hide resolved

docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved

modules/setting/federation.go Outdated Show resolved Hide resolved

Anthony Wang and others added 3 commits June 17, 2022 13:43

Add ed25519 to httpsig algorithms

47011db

Merge branch 'main' into feature-activitypub

7bfadb4

Merge branch 'main' into feature-activitypub

fe18cf7

Gusted reviewed Jun 18, 2022

View reviewed changes

modules/activitypub/client.go Outdated Show resolved Hide resolved

Use go-ap/jsonld to add @context and marshal JSON

37d2d01

Anthony Wang and others added 3 commits June 18, 2022 13:08

Change Gitea user agent from the default to Gitea/Version

7c10ab9

go mod tidy

0231dad

Merge branch 'main' into feature-activitypub

adfb213

Merge branch 'main' into feature-activitypub

1bd8eb6

delvh reviewed Jun 18, 2022

View reviewed changes

Anthony Wang and others added 4 commits June 18, 2022 16:30

Use ctx.ServerError and remove all remote interaction code from webfi…

4ffb6b6

…nger.go

Remove accidently added files

28fd3e7

Use ctx.ServerError in reqsignature.go

f602958

Merge branch 'main' into feature-activitypub

a3ff170

6543 merged commit e86f18a into go-gitea:main Jun 19, 2022

trwnh reviewed Dec 16, 2022

View reviewed changes

routers/api/v1/activitypub/person.go Show resolved Hide resolved

GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 16, 2022

trwnh mentioned this pull request Mar 29, 2023

Use ID instead of username in ActivityPub API #23802

Closed

go-gitea locked and limited conversation to collaborators May 3, 2023

Uh oh!

User keypairs and HTTP signatures for ActivityPub federation using go-ap #19133

User keypairs and HTTP signatures for ActivityPub federation using go-ap #19133

Uh oh!

Conversation

ghost commented Mar 18, 2022 • edited by 6543 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gusted left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 24, 2022

Uh oh!

Gusted commented Mar 25, 2022

Uh oh!

6543 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jun 18, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

6543 commented Jun 18, 2022

Uh oh!

ghost commented Jun 18, 2022

Uh oh!

delvh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

delvh Jun 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

6543 commented Jun 19, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ghost commented Mar 18, 2022 •

edited by 6543

Loading

ghost commented Jun 18, 2022 •

edited by ghost

Loading