Prevent double encoding of branch names in delete branch #18714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a double encoding issue in branch template whereby the branch name ends up double encoded. Fix go-gitea#18709 Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #18714 +/- ##
==========================================
- Coverage 46.44% 46.43% -0.02%
==========================================
Files 851 851
Lines 121925 121925
==========================================
- Hits 56630 56614 -16
- Misses 58413 58431 +18
+ Partials 6882 6880 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <[email protected]>
silverwind
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/done
Member
|
make L-G-T-M work. |
Member
|
Please send backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 11, 2022
* giteaofficial/main: Prevent double encoding of branch names in delete branch (go-gitea#18714) [skip ci] Updated translations via Crowdin Attempt to improve docs (yet again) (go-gitea#18687) Make the proformas clearer that we need DEBUG logs (go-gitea#18700) Update SSH Server crypto settings (go-gitea#18697) Fix bug for version update hint (go-gitea#18701)
zeripath
deleted the
fix-18709-prevent-double-encoding-in-branch-delete
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 12, 2022
) Backport go-gitea#18714 * Prevent double encoding of branch names in delete branch There is a double encoding issue in branch template whereby the branch name ends up double encoded. Fix go-gitea#18709 Signed-off-by: Andrew Thornton <[email protected]> * and tag name Signed-off-by: Andrew Thornton <[email protected]> * And fix go-gitea#18704 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
zeripath
added a commit
that referenced
this pull request
Feb 12, 2022
…8738) Backport #18714 * Prevent double encoding of branch names in delete branch There is a double encoding issue in branch template whereby the branch name ends up double encoded. Fix #18709 Signed-off-by: Andrew Thornton <[email protected]> * and tag name Signed-off-by: Andrew Thornton <[email protected]> * And fix #18704 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
) * Prevent double encoding of branch names in delete branch There is a double encoding issue in branch template whereby the branch name ends up double encoded. Fix go-gitea#18709 Signed-off-by: Andrew Thornton <[email protected]> * and tag name Signed-off-by: Andrew Thornton <[email protected]> * And fix go-gitea#18704 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a double encoding issue in branch template whereby the branch name
ends up double encoded.
Also remove Escape on issue.index in mail assignees
Fix #18709
Fix #18704
Signed-off-by: Andrew Thornton [email protected]