Skip to content

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 6, 2021

This PR adds OneDev as migration source.

Supported:

  • Milestones
  • Issues
  • Pull Requests
  • Comments
  • Reviews
  • Labels

@6543 6543 mentioned this pull request Jul 6, 2021
24 tasks
@6543 6543 added this to the 1.16.0 milestone Jul 6, 2021
@6543 6543 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 6, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2021
@codecov-commenter

This comment has been minimized.

@6543
Copy link
Member

6543 commented Aug 9, 2021

your refactor is ready and if you seperate it into it's own pull I'll lgtm it - for OneDev, there is still work to do - pulls are broken when migrated, we should be able to migrate there predefined lable set with and assign it to issues/pulls ...

@6543
Copy link
Member

6543 commented Aug 12, 2021

if a struct has time fields, it's best to compare importand fields seperate and for time converte them into timestamps before test them - this way it's more robust :) - see other migration tests

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 13, 2021
@KN4CK3R KN4CK3R requested a review from zeripath August 14, 2021 20:42
@6543
Copy link
Member

6543 commented Aug 18, 2021

@KN4CK3R please resolve conflicts :)

@lunny
Copy link
Member

lunny commented Aug 18, 2021

I think split it as two PRs is better. One is for the IssueContext and fix gitlab another is for the new feature to support OneDev.

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Aug 18, 2021

As both should not be backported and it's ready to merge I see no reason to split it (except for more work).

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2021
@6543 6543 merged commit cee5f7c into go-gitea:main Aug 21, 2021
@KN4CK3R KN4CK3R deleted the feature-migrate-onedev branch September 6, 2021 18:29
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants