Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong markdown table headers rendering #979

Closed
2 of 3 tasks
andrew-boyarshin opened this issue Feb 19, 2017 · 1 comment · Fixed by #980
Closed
2 of 3 tasks

Wrong markdown table headers rendering #979

andrew-boyarshin opened this issue Feb 19, 2017 · 1 comment · Fixed by #980
Labels
Milestone

Comments

@andrew-boyarshin
Copy link
Contributor

andrew-boyarshin commented Feb 19, 2017

Description

Table headers are measured separately from table body content. The exact reason is unknown, yet my PR seems to have triggered this error.

Originally spotted during my PR development - ignored due to buggy dev environment. Yet, it is now confirmed to be the problem thanks to @Lourens-Rich.

Possible solution

If you remove display: block from table CSS, that is _markdown.less#L243, the problem goes away. But it makes table 100% wide in parent container. The solution to that is width: auto instead of width: 100% on the next line, that is also the way it is done in Semantic UI (collapsing class on table).

If maintainers confirm that is the way to go, I can create PR with this fix.

Screenshots

chrome_2017-02-19_18-15-57


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@andreynering
Copy link
Contributor

Thank you @andrew-boyarshin

If that would fix the issue, we would be happy to receive a PR for it.

@lunny lunny added this to the 1.1.0 milestone Feb 19, 2017
@lunny lunny added the type/bug label Feb 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants