Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Triggered Twice For Issue Assignees #9578

Closed
2 of 7 tasks
giteaUser opened this issue Jan 1, 2020 · 0 comments · Fixed by #9582
Closed
2 of 7 tasks

Notifications Triggered Twice For Issue Assignees #9578

giteaUser opened this issue Jan 1, 2020 · 0 comments · Fixed by #9582
Labels
type/bug
Milestone
1.11.0

Comments

@giteaUser
Copy link

  • Gitea version (or commit ref): 1.11.0+dev-535-g60f279a86
  • Git version: not needed
  • Operating system: not needed
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When assigning users to issues, email and web hook notifications are triggered twice:

This line:
https://github.com/go-gitea/gitea/blob/master/routers/repo/issue.go#L1180

Calls this notification:
https://github.com/go-gitea/gitea/blob/master/services/issue/assignee.go#L50

Then after it returns, it again calls this notification:
https://github.com/go-gitea/gitea/blob/master/routers/repo/issue.go#L1186

This requires a similar fix to #9375
...

Screenshots
@6543 6543 mentioned this issue Jan 2, 2020
Merged
@lafriks lafriks added this to the 1.11.0 milestone Jan 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

[BugFix] Dont trigger notification twice on issue assignee change 6543-forks/gitea
2 participants
@lafriks @giteaUser