Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep preferences when submitting comment #9272

Closed
wgevaert opened this issue Dec 6, 2019 · 2 comments
Closed

Keep preferences when submitting comment #9272

wgevaert opened this issue Dec 6, 2019 · 2 comments
Labels
topic/pr Issues related to pull requests topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@wgevaert
Copy link

wgevaert commented Dec 6, 2019

  • Gitea version (or commit ref): 1.9.4
  • Git version: Not relevant
  • Operating system: Not relevant

Description

I am reviewing a big feature, using the option to ignore all whitespace changes. When I then make a comment, the whitespace preferences are discarded. (Probably because of the #issuecomment-<number> part in the url)
When I then again set my whitespace preferences, I am no longer automatically moved to the comment I just made. Hence, I have two feature requests:

  • When making a comment, your whitespace & splitscreen preferences should not be discarted.
  • When changing your preferences, you want to be moved to the comment in your URL.

I think this can be fixed by changing the comment movement parameter to a GET-variable, but I am not sure if this is indeed possible (I do not know any GO).

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 8, 2019
@mnazarov
Copy link

mnazarov commented Mar 4, 2021

I think it can also be considered as a bug, because in some cases when the whitespace setting is reset after pressing 'add commit' the page can't restore the reading position with the anchor link (I guess because it shows different lines then before)

related report: #13758

@zeripath zeripath added topic/ui Change the appearance of the Gitea UI topic/pr Issues related to pull requests labels Mar 5, 2021
@wxiaoguang
Copy link
Contributor

It has been fixed by #15566

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/pr Issues related to pull requests topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants