Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting changes in PR doesn't trigger webhook #8322

Closed
2 of 7 tasks
dochan-consultis opened this issue Sep 30, 2019 · 0 comments · Fixed by #8570
Closed
2 of 7 tasks

Requesting changes in PR doesn't trigger webhook #8322

dochan-consultis opened this issue Sep 30, 2019 · 0 comments · Fixed by #8570
Labels
type/enhancement An improvement of existing functionality

Comments

@dochan-consultis
Copy link

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.23.0
  • Operating system: Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

In case when you:

  1. Create PR
  2. Start review
  3. Create multiple comments
  4. Request changes

It doesn't trigger webhook for pull_request_rejected action.
@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 30, 2019
@jolheiser jolheiser mentioned this issue Oct 18, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement/Fix PR review webhooks jolheiser/gitea
2 participants
@lunny @dochan-consultis