Commits should only close/reopen issues if the issue has the correct branch

[guillep2k]

• Gitea version (or commit ref): 1.9.3

Description

Currently a commit can close or reopen an issue it is referencing, either if repo.CloseIssuesViaCommitInAnyBranch is set or when the commit is being pushed to the default branch. However, if Issue.Ref is set, it should be used instead of the default branch.

gitea/models/action.go

Lines 603 to 607 in 63ff616

	// Change issue status only if the commit has been pushed to the default branch.
	// and if the repo is configured to allow only that
	if repo.DefaultBranch != branchName && !repo.CloseIssuesViaCommitInAnyBranch {
	continue
	}

[adelowo]

It is there for backward compatibility

See #5992 and #5957

[guillep2k]

It is there for backward compatibility

See #5992 and #5957

@adelowo Using CloseIssuesViaCommitInAnyBranch is alright, but if it's not set, an the issue is marked on branch release (Issue.Ref == release), a commit on dev should not close the issue.

[adelowo]

Ha true

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[guillep2k]

This was fixed in #8875