RocketChat notification for pull request comment has not working hyperlink

[mathysie]

• Gitea version (or commit ref): 1.9.2
• Git version:
• Operating system: Ubuntu 18.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

After placing a comment in a pull request, a notification is send to our Rocket.Chat. The notification tries to provide a hyperlink to the message with the syntax <"hyperlink"|"name pull request">. This is correct, however it is used as a header as well. Therefore, instead of making a hyperlink to the Gitea server, Rocket.Chat creates a hyperlink to show the contents of the comment.

I suggest to change the comment notification to:

[foo] New comment created by <"hyperlink to user"|"user">: <"hyperlink to comment"|"name pull request">
> "Comment contents"

This method will render all hyperlinks correctly.

Screenshots

[lunny]

Which webhook type did you use?

[mathysie]

We are using the slack hook

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[cornelk]

@mathysie please test again with v1.10.2 or later, this should be fixed with #9422

[lafriks]

Closing as fixed, reopen if there is still a problem