Repo with existing directory misleadingly fails with 500

[commel]

Hi,

• Gitea version (or commit ref):
• Git version: 1.8.3
• Operating system: Windows Server 2019 DS 1809
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No (because i cant delete a repo without removing its directory there)
  • Not relevant

Description

we switched servers (and datbase backends from sqlite3 to mssql) but keeped the repository directories. I needed to recreate the former existing repository entries in gitea. After clicking "create repository" it resulted in a 500 error page. After refresh the empty repository was available.

In the logs I found this:
2019/07/08 10:00:23 [...routers/repo/repo.go:146 handleCreateError()] [E] CreatePost: initRepository: initRepository: path already exists: d:\repos\secretuser\secretrepo.git

The error is misleading (and probably not wanted in that way) here as it works in the background. A notification message would be better to inform that the directory is already existing.

[dimmuboy]

I have same error with empty MSSQL database and initial Gitea config. I tried add LOCAL_ROOT_URL = http://127.0.0.1:3000 to config, change permissions, database, new 1.9.0 version but still same error.

[lunny]

@dimmuboy Did you also have an exist repository on the same path as your created?

[dimmuboy]

@dimmuboy Did you also have an exist repository on the same path as your created?

No I created completely new repo dir

[lunny]

@dimmuboy Did you also have an exist repository on the same path as your created?

No I created completely new repo dir

So you should have a different issue as this one.

[dimmuboy]

So you should have a different issue as this one.

Yes but IMHO it will be problem with database because main dir sctructure "repository/username/" was created. In original post @commel wrote about switch to MSSQL like me.

Edit: In my case error 500 shows only when creating new repo and check Initialize Repository otherwise repo is created.

[wxiaoguang]

It has been fixed #24164 by the way