Add doctor command to write commit-graphs #20007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a doctor command to write the commit-graphs for the repositories: `gitea doctor --run check-commit-graphs --fix` Signed-off-by: Andrew Thornton <[email protected]>
Contributor
Author
|
could be moved to 1.17 |
GiteaBot
added
the
lgtm/need 2
Gusted
reviewed
Jun 17, 2022
Signed-off-by: Andrew Thornton <[email protected]>
delvh
reviewed
Jun 17, 2022
|
|
||
| if !isExist { | ||
| commitGraphsDir := path.Join(repo.RepoPath(), `objects/info/commit-graphs`) | ||
| isExist, err = util.IsExist(commitGraphsDir) |
Member
There was a problem hiding this comment.
Isn't there a case missing that this directory is not empty?
Or what is the file format inside this directory?
Shouldn't this be checked as well?
Contributor
Author
There was a problem hiding this comment.
I don't think its worth checking for the format of the directory and/or file at this point.
If you are really interested in how commit graphs are created you are welcome to peruse:
and
Here is the salient points for the contents of commit-graphs
A commit-graph chain uses multiple files, and we use a fixed naming convention
to organize these files. Each commit-graph file has a name
`$OBJDIR/info/commit-graphs/graph-{hash}.graph` where `{hash}` is the hex-
valued hash stored in the footer of that file (which is a hash of the file's
contents before that hash). For a chain of commit-graph files, a plain-text
file at `$OBJDIR/info/commit-graphs/commit-graph-chain` contains the
hashes for the files in order from "lowest" to "highest".
We could assert that the chain file exists instead of the directory I guess.
delvh
reviewed
Jun 17, 2022
Gusted
approved these changes
Jun 23, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jun 23, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a doctor command to write the commit-graphs for the repositories:
gitea doctor --run check-commit-graphs --fixSigned-off-by: Andrew Thornton [email protected]