NPE in routers/web/feed/profile.go:37 on 1.16.7 following failed migration

[zeripath]

Extract from a comment in #19613

2022/05/05 20:06:26 ...s/graceful/server.go:61:NewServer() [I] Starting new Web server: tcp:0.0.0.0:3000 on PID: 16
2022/05/05 20:06:46 Started GET / for 10.###.###.###:0
2022/05/05 20:06:46 routers/web/base.go:130:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:220 (0x457635)
/usr/local/go/src/runtime/signal_unix.go:818 (0x457605)
/go/src/code.gitea.io/gitea/routers/web/feed/profile.go:37 (0x1fbb59c)
/go/src/code.gitea.io/gitea/routers/web/user/home.go:134 (0x1fd20d2)
/go/src/code.gitea.io/gitea/routers/web/home.go:41 (0x2034770)
/go/src/code.gitea.io/gitea/modules/web/route.go:74 (0x1e47d44)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x1656dd5)
/usr/local/go/src/net/http/server.go:2084 (0x7ac6ce)
...

The migration consists of pushing cloned repo's from GitHub into Gitea, the repo's are created using the API and data transferred using Git https.

Now that I have migrated a few more repo's, the 500 error on the landing page is gone. Presumably because whatever was causing it is not longer shown on it.

Originally posted by @number42net in #19613 (comment)

[zeripath]

The line in 1.16 is:

gitea/routers/web/feed/profile.go

Line 37 in 46637b1

repoOwner, ok := userCache[act.Repo.OwnerID]

And implies that act.Repo is nil which would imply that it was not being set in here:

gitea/models/action_list.go

Lines 63 to 81 in 46637b1

	func (actions ActionList) loadRepositories(e db.Engine) ([]*repo_model.Repository, error) {
	if len(actions) == 0 {
	return nil, nil
	}
	repoIDs := actions.getRepoIDs()
	repoMaps := make(map[int64]*repo_model.Repository, len(repoIDs))
	err := e.
	In("id", repoIDs).
	Find(&repoMaps)
	if err != nil {
	return nil, fmt.Errorf("find repository: %v", err)
	}
	for _, action := range actions {
	action.Repo = repoMaps[action.RepoID]
	}
	return valuesRepository(repoMaps), nil
	}

Likely because the repository does not exist.

Now, this code has changed a lot on main, so whilst there's a clear fix in 1.16 I'm not sure if 1.17 is affected.

[zeripath]

and in fact it appears that this is very likely related to #19598

[number42net]

@zeripath Thanks for opening this and for looking into it!

[Gusted]

PR's are merged, but for some reason Github didn't think about closing the linked issue.