Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] add option to update pull request by rebase #16019

Closed
a1012112796 opened this issue May 29, 2021 · 3 comments · Fixed by #16125
Closed

[Proposal] add option to update pull request by rebase #16019

a1012112796 opened this issue May 29, 2021 · 3 comments · Fixed by #16125
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@a1012112796
Copy link
Member

a1012112796 commented May 29, 2021

As we all know, do git rebase main(base_branch) and then force push to the head branch also can set the base of head branch update to the base branch, So I think maybe we can also add it as
a optional way on ui. Thanks

@a1012112796 a1012112796 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 29, 2021
@lunny
Copy link
Member

lunny commented May 30, 2021

Didn't we have implemented that? You can find a button named Update when the pull request base head branch moved.

@nils91
Copy link
Contributor

nils91 commented May 31, 2021

The update button does a git merge base_branch to update the PR, not a rebase. I think the relevant function is in
services/pull/update.go.

@a1012112796
Copy link
Member Author

@lunny I know it, It use git merge base_branch, but as we all know, git rebase base_branch can do same thing. So like we provide more than one way to merge a pull request. I think we can also provide more than one way to update pull request also, Thanks.

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants