Allow disable pr body as commit message when squash merge

[viceice]

• Gitea version (or commit ref): 1.14.2
• Git version: official gitea docker image from above
• Operating system: official gitea docker (kubernetes helm)
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
• Log gist:

Description

PR #13071 added the pr body to the squash commit message. I like to have an option to disable this behavior.
I'm using renovate to manage my dependencies and always squash my PR's.
The renovate PR descriptions can be very long because of changelogs, so i would like to exclude the content as i can do for commits with:

[repository.pull-request]
DEFAULT_MERGE_MESSAGE_COMMITS_LIMIT=0

I would be happy to help to add such an option if it is welcome. 🙃

Screenshots

[viceice]

I think it should repect DEFAULT_MERGE_MESSAGE_SIZE=0 here:

gitea/services/pull/pull.go

Lines 573 to 577 in 1da0d15

	stringBuilder.WriteString(pr.Issue.Content)
	if stringBuilder.Len() > 0 {
	stringBuilder.WriteRune('\n')
	stringBuilder.WriteRune('\n')
	}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[viceice]

Any feedback?

[zeripath]

Set POPULATE_SQUASH_COMMENT_WITH_COMMIT_MESSAGES = true and DEFAULT_MERGE_MESSAGE_SIZE=0

[viceice]

Set POPULATE_SQUASH_COMMENT_WITH_COMMIT_MESSAGES = true and DEFAULT_MERGE_MESSAGE_SIZE=0

OK. so that will only work for gitea v1.15? Any ETA? 🙃

Will gitea v1.14.x ignore setting POPULATE_SQUASH_COMMENT_WITH_COMMIT_MESSAGES=true ?

[viceice]

Fixed by #16134 in gitea v1.15

[viceice]

@zeripath Can you add this to the v1.15 milestore?