Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox rendering in issues #1541

Closed
2 of 7 tasks
mirhec opened this issue Apr 25, 2017 · 4 comments · Fixed by #1709
Closed
2 of 7 tasks

Fix checkbox rendering in issues #1541

mirhec opened this issue Apr 25, 2017 · 4 comments · Fixed by #1709
Labels
Milestone

Comments

@mirhec
Copy link

mirhec commented Apr 25, 2017

Description

You can create checkboxes via the [ ] brackets, but there always is a line break after the checkbox. The following issue-content

## Checkbox

- [ ] Test 1
- [x] Test 2
- [ ] Test 1

renders to

image

@lunny lunny added the type/bug label Apr 26, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 26, 2017
@silverwind
Copy link
Member

silverwind commented Apr 26, 2017

They are wrapped by a bare <div>, which should probably just be removed.

Also, it'd be great if they were checkable and that these state changes would edit the underlying markdown (if the user has edit permission), but that's probably more complicated to realize.

@pree
Copy link

pree commented Apr 27, 2017

This has probably something to do with #186

@kenogo
Copy link

kenogo commented Apr 11, 2019

Is there a reason to keep the bullets next to the checkboxes? It seems like quite an unusual way to handle it. At least GitHub and GitLab both don't do it.

@lunny
Copy link
Member

lunny commented Apr 11, 2019

@kenogo please fire another issue to discuss that.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants