-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install form layout is broken #1343
Comments
I wouldn't directly call it broken as still seems to work, but it looks bad/ugly. |
@tboerger semantics. It looks pretty broken to me. Usable, but broken. |
It's broken I think. @strk |
Tge only change in a9de85d is adding !important to some CSS and was done by |
Here is what make think that it was since a9de85d.
Before a9de85d commit:
After a9de85d commit:
|
So it looks like the .css generated by my version of less compiler isn't good, if that's the case we should make the Makefile rule refuse to update index.css with an unexpected .css. Can you please try to Can you help checking this @geek1011 ? (as my favorite resident CSS guy :) |
@strk is this resolved? |
As of current master (bb14c97) it seems to be fixed, yes. Feel free to close (I don't have a close button) |
Change made by less version of @strk was revert in one of my commit @912b340d0d674b35ef04e66d00a10a8e4a02e82c (in master) because of re-generation of the file by less (maybe not the same version). So if it was the source of the bug it's corrected in master. |
So let's close this. @aloupfor please feel free to reopen it. |
@sapk here I have |
Maybe we need a command |
One rule to generate the css exists:
make public/css/index.css
Having a "css" alias sounds good to me, and "test-css" to go with it
(invoked as a dependency of "test" so we dont' have to change Drone).
Note this is similar to what I tried to achieve with #1366, which was
also affected by different versions of tooling...
|
[x]
):Description
I'm installing gitea using this documentation: https://docs.gitea.io/en-us/install-from-source/.
Since this commit: a9de85d, the layout on the install form seems broken.
If I'am not wrong the fields were previously centred on the page.
Screenshot
The text was updated successfully, but these errors were encountered: