Fix file name could not be searched if the file was not a text file when using the Bleve indexer (#33959)

charles7668 · wxiaoguang · web-flow · commit b956cee06f46 · 2025-03-21T19:00:02.000Z
Close #33828 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/modules/indexer/code/bleve/bleve.go b/modules/indexer/code/bleve/bleve.go
@@ -191,7 +191,8 @@ func (b *Indexer) addUpdate(ctx context.Context, batchWriter git.WriteCloserErro
 		return err
 	} else if !typesniffer.DetectContentType(fileContents).IsText() {
 		// FIXME: UTF-16 files will probably fail here
-		return nil
+		// Even if the file is not recognized as a "text file", we could still put its name into the indexers to make the filename become searchable, while leave the content to empty.
+		fileContents = nil
 	}
 
 	if _, err = batchReader.Discard(1); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,8 @@ func (b *Indexer) addUpdate(ctx context.Context, batchWriter git.WriteCloserErro`
`191`	`191`	`return err`
`192`	`192`	`} else if !typesniffer.DetectContentType(fileContents).IsText() {`
`193`	`193`	`// FIXME: UTF-16 files will probably fail here`
`194`		`- return nil`
	`194`	`+ // Even if the file is not recognized as a "text file", we could still put its name into the indexers to make the filename become searchable, while leave the content to empty.`
	`195`	`+ fileContents = nil`
`195`	`196`	`}`
`196`	`197`
`197`	`198`	`if _, err = batchReader.Discard(1); err != nil {`