Make buttons in a modal form have proper type. (#25446)

wxiaoguang · silverwind · GiteaBot · web-flow · commit a954c93a6807 · 2023-06-23T12:57:01.000+02:00
Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js
@@ -395,6 +395,8 @@ function initGlobalShowModal() {
     if (colorPickers.length > 0) {
       initCompColorPicker(); // FIXME: this might cause duplicate init
     }
+    // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"
+    $modal.find('form button:not(.ok):not([type])').attr('type', 'button');
     $modal.modal('setting', {
       onApprove: () => {
         // "form-fetch-action" can handle network errors gracefully,

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,8 @@ function initGlobalShowModal() {`
`395`	`395`	`if (colorPickers.length > 0) {`
`396`	`396`	`initCompColorPicker(); // FIXME: this might cause duplicate init`
`397`	`397`	`}`
	`398`	`+ // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"`
	`399`	`+ $modal.find('form button:not(.ok):not([type])').attr('type', 'button');`
`398`	`400`	`$modal.modal('setting', {`
`399`	`401`	`onApprove: () => {`
`400`	`402`	`// "form-fetch-action" can handle network errors gracefully,`