Prevent NPE when checking repo units if the user is nil (#19625)

zeripath · wxiaoguang · web-flow · commit a7f52684cb7e · 2022-05-06T11:54:22.000+08:00
CheckRepoUnitUser should tolerate nil users. Fix #19613 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/models/repo.go b/models/repo.go
@@ -54,7 +54,7 @@ func CheckRepoUnitUser(repo *repo_model.Repository, user *user_model.User, unitT
 }
 
 func checkRepoUnitUser(ctx context.Context, repo *repo_model.Repository, user *user_model.User, unitType unit.Type) bool {
-	if user.IsAdmin {
+	if user != nil && user.IsAdmin {
 		return true
 	}
 	perm, err := GetUserRepoPermission(ctx, repo, user)

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ func CheckRepoUnitUser(repo repo_model.Repository, user user_model.User, unitT`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`func checkRepoUnitUser(ctx context.Context, repo repo_model.Repository, user user_model.User, unitType unit.Type) bool {`
`57`		`- if user.IsAdmin {`
	`57`	`+ if user != nil && user.IsAdmin {`
`58`	`58`	`return true`
`59`	`59`	`}`
`60`	`60`	`perm, err := GetUserRepoPermission(ctx, repo, user)`