add migration and fix lint

Author: lunny

models/migrations/migrations.go

@@ -258,6 +258,8 @@ var migrations = []Migration{
 	NewMigration("update migration repositories' service type", updateMigrationServiceTypes),
 	// v101 -> v102
 	NewMigration("change length of some external login users columns", changeSomeColumnsLengthOfExternalLoginUser),
+	// v102 -> v103
+	NewMigration("update migration repositories' service type", dropColumnHeadUserNameOnPullRequest),
 }
 
 // Migrate database to current version

models/migrations/v102.go

@@ -0,0 +1,15 @@
+// Copyright 2019 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package migrations
+
+import (
+	"xorm.io/xorm"
+)
+
+func dropColumnHeadUserNameOnPullRequest(x *xorm.Engine) error {
+	sess := x.NewSession()
+	defer sess.Close()
+	return dropTableColumns(sess, "pull_request", "head_user_name")
+}

models/pull.go

@@ -121,7 +121,7 @@ func (pr *PullRequest) LoadBaseRepo() error {
 	return nil
 }
 
-// LoadBaseRepo loads pull request base repository from database
+// LoadHeadRepo loads pull request head repository from database
 func (pr *PullRequest) LoadHeadRepo() error {
 	if pr.HeadRepo == nil {
 		if pr.HeadRepoID == pr.BaseRepoID && pr.BaseRepo != nil {