Never allow an empty password to validate (#9682) (#9683)

zeripath · lafriks · lafriks · commit 7eaba6ba8ab2 · 2020-01-11T16:27:03.000+02:00
* Restore IsPasswordSet previous value

* Update models/user.go

Co-authored-by: Lauris BH &lt;lauris@nix.lv&gt;
diff --git a/models/user.go b/models/user.go
@@ -503,7 +503,7 @@ func (u *User) ValidatePassword(passwd string) bool {
 
 // IsPasswordSet checks if the password is set or left empty
 func (u *User) IsPasswordSet() bool {
-	return len(u.Passwd) > 0
+	return !u.ValidatePassword("")
 }
 
 // UploadAvatar saves custom avatar for user.

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,7 @@ func (u *User) ValidatePassword(passwd string) bool {`
`503`	`503`
`504`	`504`	`// IsPasswordSet checks if the password is set or left empty`
`505`	`505`	`func (u *User) IsPasswordSet() bool {`
`506`		`- return len(u.Passwd) > 0`
	`506`	`+ return !u.ValidatePassword("")`
`507`	`507`	`}`
`508`	`508`
`509`	`509`	`// UploadAvatar saves custom avatar for user.`