Fix 2-dot direct compare to use the right base commit (#24133)

jtran · web-flow · commit 1af3dc6ee35b · 2023-04-16T10:27:23.000+03:00
For 2-dot direct compare, we should use the base commit in the title and templates, as is used elsewhere, not the common ancestor which is used for 3-dot compare. I believe that this change should have been included in #22949.
diff --git a/routers/web/repo/compare.go b/routers/web/repo/compare.go
@@ -551,7 +551,11 @@ func ParseCompareInfo(ctx *context.Context) *CompareInfo {
 		ctx.ServerError("GetCompareInfo", err)
 		return nil
 	}
-	ctx.Data["BeforeCommitID"] = ci.CompareInfo.MergeBase
+	if ci.DirectComparison {
+		ctx.Data["BeforeCommitID"] = ci.CompareInfo.BaseCommitID
+	} else {
+		ctx.Data["BeforeCommitID"] = ci.CompareInfo.MergeBase
+	}
 
 	return ci
 }

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,11 @@ func ParseCompareInfo(ctx context.Context) CompareInfo {`
`551`	`551`	`ctx.ServerError("GetCompareInfo", err)`
`552`	`552`	`return nil`
`553`	`553`	`}`
`554`		`- ctx.Data["BeforeCommitID"] = ci.CompareInfo.MergeBase`
	`554`	`+ if ci.DirectComparison {`
	`555`	`+ ctx.Data["BeforeCommitID"] = ci.CompareInfo.BaseCommitID`
	`556`	`+ } else {`
	`557`	`+ ctx.Data["BeforeCommitID"] = ci.CompareInfo.MergeBase`
	`558`	`+ }`
`555`	`559`
`556`	`560`	`return ci`
`557`	`561`	`}`