Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/dap: clear breakpoints before disconnecting for attach mode #3083

Open
hyangah opened this issue Jul 28, 2022 · 2 comments
Open

service/dap: clear breakpoints before disconnecting for attach mode #3083

hyangah opened this issue Jul 28, 2022 · 2 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 28, 2022

Spin-off from #2958 (comment)

Original feature request: golang/vscode-go#2368

While #2958 discusses a bigger refactoring work, we want to clear all breakpoints/logpoints before disconnecting.
Related: #1961

We were told Goland explicitly issues the ClearBreakpoints command before exiting, which I think is a good default behavior.

For users who really want to keep the debug target running with breakpoints set, if any, we can consider this as a launch attribute optionally, but IMO that's unusual case.

cc @suzmue @polinasok

@polinasok
Copy link
Collaborator

Ah, should have added my update here, not at #2958 (comment).

But basically last time we had a vscode-go/delve group chat about this, I was sort of pushing for clearing (because it would make the async logic covered in #2958 soooo much simpler), but the consensus was that we need to give users the flexibility both ways with an option to do either (keep or clear). Time to revisit that decision? :)

@OrBin
Copy link

OrBin commented Aug 11, 2022

@polinasok do you have any update on this? did you decide to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants